Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/volume migration #34

Merged
merged 10 commits into from
Apr 19, 2022
Merged

Feature/volume migration #34

merged 10 commits into from
Apr 19, 2022

Conversation

maxan98
Copy link
Contributor

@maxan98 maxan98 commented Apr 18, 2022

Description

Migrator Sidecar Introduced
MVP Migration Logic

GitHub Issues

List the GitHub issues impacted by this PR:
dell/csm#265
dell/csm#267

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Manually e2e

@maxan98 maxan98 requested a review from AronAtDell as a code owner April 18, 2022 12:51
@maxan98 maxan98 self-assigned this Apr 18, 2022
walker2
walker2 reviewed Apr 18, 2022
View reviewed changes
walker2
walker2 reviewed Apr 19, 2022
View reviewed changes
@maxan98 maxan98 merged commit aaed962 into main Apr 19, 2022
@maxan98 maxan98 deleted the feature/VolumeMigration branch April 19, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walker2 walker2 walker2 approved these changes

@IliaRN IliaRN IliaRN approved these changes

@AronAtDell AronAtDell Awaiting requested review from AronAtDell

@gallacher gallacher Awaiting requested review from gallacher

@vlad-belogrudov vlad-belogrudov Awaiting requested review from vlad-belogrudov

@delldubey delldubey Awaiting requested review from delldubey

@alinamullagalieva alinamullagalieva Awaiting requested review from alinamullagalieva

Assignees

@maxan98 maxan98

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxan98 @walker2 @IliaRN