Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(e2e): add OPA remote module e2e test #850

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

nacx
Copy link
Contributor

@nacx nacx commented Dec 12, 2024

Description

Now that #826 is merged and we have a .rego file in the repository, we can add an e2e test that exercises the remote module import path.

Related Issue

Relates to #826

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Signed-off-by: Ignasi Barrera <nacx@apache.org>
@nacx nacx requested a review from a team as a code owner December 12, 2024 17:46
@meganwolf0
Copy link
Collaborator

Looks like one of the unit tests for network is failing (looking for the checksum of the file changed) - should be a quick update!

Signed-off-by: Ignasi Barrera <nacx@apache.org>
@nacx
Copy link
Contributor Author

nacx commented Dec 12, 2024

Missed those. Should be ok now!

Copy link
Contributor

@mildwonkey mildwonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 thank you for submitting this!

Copy link
Member

@brandtkeller brandtkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great call getting this integrated into the existing test.

@brandtkeller brandtkeller merged commit 5e0b2d0 into defenseunicorns:main Dec 13, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants