feat: exponential backoff with exp decreasing batch size for opensearch and elasticsearch client #3194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArzelaAscoIi
requested review from
bogdankostic
and removed request for
a team
6 tasks
…gin/master/feat/opensearchDocumentStoreRetry
6 tasks
masci
suggested changes
Sep 13, 2022
Co-authored-by: Massimiliano Pippi <mpippi@gmail.com>
…hub.com:deepset-ai/haystack into origin/master/feat/opensearchDocumentStoreRetry
masci
suggested changes
Sep 13, 2022
ArzelaAscoIi
deleted the
origin/master/feat/opensearchDocumentStoreRetry
branch
|
Isn't this feature for both opensearch and elasticsearch? If yes, let's change the PR title so that we have it correctly in the next release notes. |
ArzelaAscoIi
changed the title
|
Yes :) Adjusted the title |
brandenchan
pushed a commit
that referenced
this pull request
Sep 21, 2022
…ch client (#3194) * Validate custom_mapping properly as an object * Remove related test * black * feat: exponential backoff with exp dec batch size * added docstring and split doc lsit * fix * fix mypy * fix * catch generic exception * added test * mypy ignore * fixed no attribute * added test * added tests * revert strange merge conflicts * revert merge conflict again * Update haystack/document_stores/elasticsearch.py Co-authored-by: Massimiliano Pippi <mpippi@gmail.com> * done * adjust test * remove not required caplog * fixed comments Co-authored-by: ZanSara <sarazanzo94@gmail.com> Co-authored-by: Massimiliano Pippi <mpippi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
_bulkinsert for opensearch + elasticsearch clientHow did you test it?
Note to the reviewer
There is also a bulk insert for the
clone_embedding_fieldwithin the openserach document store. Do we also need to update this ? Currently we just inherit the bulk insert for opensearch from elasticsearch.I had to merge this branch: #3189 to test it
Checklist