feat: Add warnings to PineconeDocumentStore about indexing metadata if filters return no documents #3086
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
This pull request adds a warning for
query_by_embedding
andget_all_documents_generator
in PineconeDocumentStore when a filter is used through an user action but no results are obtained. As it is referenced in this issue #3021, there's no way to know which metadata fields are indexed currently, so these warnings serve as a hint for users to revisit their queries in the circumstances referenced above (used a filter + no results obtained).How did you test it?
query_by_embedding
tested ✅(Edited Tutorial 1 with some help from this notebook here that was added as testing material in the PineconeDocumentStore implementation PR #2254get_all_documents_generator
tested ✅ through the upstream methodget_all_documents
Notes for the reviewer
I have preemptively opened the pull request as it is encouraged in the CONTRIBUTING section.
I am still exploring the framework and this is my first os pull request so bear with me 😅.
Checklist