-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix JoinAnswer/JoinNode #2612
Fix JoinAnswer/JoinNode #2612
Conversation
… into fix-join-nodes
… into fix-join-nodes
@MichelBartels I had a look at the changes, good progess! I will review them shortly, but first of all let me highlight one thing: let's not mess with the
I will link this PR to the ones related to |
Hey @MichelBartels how about this one? Shall I take care of it? It's not urgent but I'd like to see this in master 🙂 |
Hi @ZanSara, sorry forgot a bit about this. I have now done your suggested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thank you very much for this PR 😊 Hopefully the issues you had to work around will be fixed very soon.
* fix join nodes * Update Documentation & Code Style * fix unused import * change arg order * Update Documentation & Code Style * fix kwargs check * add warning when there is only one input node * Update Documentation & Code Style * fix type hint * fix wrong import order * Update Documentation & Code Style * undo kwargs * add accidentally deleted newline# * fix type hint * fix type hint Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Proposed changes:
As described in #2599 and #2593, there are currently issues with nodes that can accept multiple inputs. This PR addresses these by changing the nodes and not the pipelines like in #2593.
Status (please check what you already did):