Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce debug as a valid global key for Pipeline's params #2298

Merged
merged 3 commits into from
Mar 11, 2022
Merged

Reintroduce debug as a valid global key for Pipeline's params #2298

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a9836ec
Add debug in the valid global params for run()
ZanSara Mar 10, 2022
52aab79
strings are iterables
ZanSara Mar 10, 2022
24c70bb
Merge branch 'master' into fix_global_debug_param
ZanSara Mar 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion haystack/pipelines/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,7 +590,7 @@ def run( # type: ignore

# Might be a non-targeted param. Verify that too
not_a_node = set(params.keys()) - set(self.graph.nodes)
valid_global_params = set()
valid_global_params = set(["debug"]) # Debug will be picked up by _dispatch_run, see its code
for node_id in self.graph.nodes:
run_signature_args = inspect.signature(self.graph.nodes[node_id]["component"].run).parameters.keys()
valid_global_params |= set(run_signature_args)
Expand Down