fix: get_documents_by_id should return docs for all passed ids #2064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julian-risch
approved these changes
Jan 25, 2022
| """Fetch documents by specifying a list of text id strings""" | ||
| """ | ||
| Fetch documents by specifying a list of text id strings. Be aware that passing a large number of ids might lead | ||
| to performance issues. |
There was a problem hiding this comment.
You could mention here that the maximum is 10,000 (with elasticsearch). We might even limit that further to prevent performance issues.
There was a problem hiding this comment.
I'll add a short sentence about the 10k ES default limit. And I think it's a good idea to monitor first before limiting it for performance reasons. If we decide to limit this we should probably also limit other queries, shouldn't we?
ZanSara
added
journey:first steps
topic:document_store
type:bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
ElasticsearchDoumentStore'sget_all_documents_by_idmethod should return documents for all ids that where passed in. Previously, a maximum of 10 documents was returned.Status (please check what you already did):