Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENG-188] Role card updates #2720

Merged
merged 4 commits into from
Feb 10, 2025
Merged

[ENG-188] Role card updates #2720

merged 4 commits into from
Feb 10, 2025
+9 −102

Conversation

Da-Colon
Copy link
Contributor

@Da-Colon Da-Colon commented Feb 7, 2025

Closes ENG-188
Works on ENG-68

Screenshots

Before:

develop decent-interface pages dev_roles_details_dao=sep_0x1Fa0B200fB7ADd92A8462f8455eA06350eC233C4 hatId=0x0000037100010002000000000000000000000000000000000000000000000000(Mobile)

After:

localhost_3000_roles_dao=sep_0x1Fa0B200fB7ADd92A8462f8455eA06350eC233C4(Mobile)

Changes

  • Adjusted alignment of name, display 'address', and payment count
  • Remove border around display 'address' (or ens name)
  • Remove 'copy address' from RoleCard, as this is mobile and can't click this.
  • Fixed conditional incorrectly showing 'inactive' tag
  • Also fixed conditional in Roles Table showing wrong color for member name.

@Da-Colon Da-Colon self-assigned this Feb 7, 2025
@linear Linear
Copy link

linear bot commented Feb 7, 2025

ENG-188 Role Card

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Feb 7, 2025 •
edited
Loading

Deploying decent-interface with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7408e13
Status: ✅  Deploy successful!
Preview URL: https://17a11797.decent-interface.pages.dev
Branch Preview URL: https://eng-188-role-card-updates.decent-interface.pages.dev

View logs

@Da-Colon Da-Colon requested a review from a team February 7, 2025 08:10
@Da-Colon Da-Colon merged commit 8a2e9f3 into develop Feb 10, 2025
4 checks passed
@Da-Colon Da-Colon deleted the eng-188-role-card-updates branch February 10, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamgall adamgall adamgall approved these changes

@DarksightKellar DarksightKellar DarksightKellar approved these changes

@johnqh johnqh Awaiting requested review from johnqh

@mudrila mudrila Awaiting requested review from mudrila

Assignees

@Da-Colon Da-Colon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Da-Colon @adamgall @DarksightKellar