Eng 61 update subgraph endpoints #2708
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -33,9 +33,6 @@ yarn-error.log* | |
| # translation script outputs | ||
| *.csv | ||
|
|
||
| # Wrangler | ||
| /.wrangler | ||
| .dev.vars | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| export const ExtendedSnapshotProposalQuery = `query ExtendedSnapshotProposal($snapshotProposalId: String!) { | ||
| proposal(id: $snapshotProposalId) { | ||
| snapshot | ||
| type | ||
| quorum | ||
| privacy | ||
| strategies { | ||
| name | ||
| network | ||
| params | ||
| } | ||
| plugins | ||
| choices | ||
| ipfs | ||
| } | ||
| }`; | ||
|
|
||
| export const SnapshotProposalVotesQuery = `query SnapshotProposalVotes($snapshotProposalId: String!) { | ||
| votes(where: { proposal: $snapshotProposalId }, first: 500) { | ||
| id | ||
| voter | ||
| vp | ||
| vp_by_strategy | ||
| vp_state | ||
| created | ||
| choice | ||
| } | ||
| }`; | ||
|
|
||
| export const UserVotingWeightQuery = `query UserVotingWeight($voter: String!, $space: String!, $proposal: String!) { | ||
| vp(voter: $voter, space: $space, proposal: $proposal) { | ||
| vp | ||
| vp_by_strategy | ||
| vp_state | ||
| } | ||
| }`; | ||
|
|
||
| export const ProposalsQuery = `query Proposals($spaceIn: [String!]) { | ||
| proposals( | ||
| first: 50, | ||
| where: { | ||
| space_in: $spaceIn | ||
| }, | ||
| orderBy: "created", | ||
| orderDirection: desc | ||
| ) { | ||
| id | ||
| title | ||
| body | ||
| choices | ||
| start | ||
| end | ||
| snapshot | ||
| state | ||
| author | ||
| space { | ||
| id | ||
| name | ||
| } | ||
| } | ||
| }`; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,57 @@ | ||
| import { cacheExchange, createClient, fetchExchange } from 'urql'; | ||
| import { NetworkConfig, TheGraphConfig } from '../types/network'; | ||
|
|
||
| // Cache to store client instances by their unique URL | ||
| const clientCache = new Map<string, ReturnType<typeof createClient>>(); | ||
|
|
||
| const createTheGraphClient = (config: TheGraphConfig) => { | ||
| const theGraphAPIKey = import.meta.env.VITE_APP_THEGRAPH_API_KEY; | ||
|
|
||
| const url = import.meta.env.DEV | ||
| ? `https://api.studio.thegraph.com/query/${config.space}/${config.slug}/version/latest` | ||
| : `https://gateway.thegraph.com/api/${theGraphAPIKey}/subgraphs/id/${config.id}`; | ||
|
|
||
| // Check if we already have a client for this URL | ||
| const cachedClient = clientCache.get(url); | ||
| if (cachedClient) { | ||
| return cachedClient; | ||
| } | ||
|
Comment on lines
+14
to
+18
There was a problem hiding this comment. Why do we cache the client? looking at the documentation, and is this instead of create a context provider? There was a problem hiding this comment. Decided to implement this lil caching mechanism (thanks for the suggestion @mudrila), specifically because I've removed the context provider. Wherever we need to utilize a graphql client, we create (or get from cache) an instance of it on the fly, instead of using the "one" that would be in a Provider context. Decided to do it like this because of how diverse our graphql clients are. Effectively the "url" property of a I didn't really do any profiling to see how expensive it is to create these different clients, but the caching layer here is so light it seemed like a simple thing to implement. |
||
|
|
||
| // Create new client if not cached | ||
| const client = createClient({ | ||
| url, | ||
| exchanges: [cacheExchange, fetchExchange], | ||
| }); | ||
|
|
||
| // Cache the new client | ||
| clientCache.set(url, client); | ||
| return client; | ||
| }; | ||
|
|
||
| export const createDecentSubgraphClient = (networkConfig: NetworkConfig) => { | ||
| return createTheGraphClient(networkConfig.decentSubgraph); | ||
| }; | ||
|
|
||
| export const createSablierSubgraphClient = (networkConfig: NetworkConfig) => { | ||
| return createTheGraphClient(networkConfig.sablierSubgraph); | ||
| }; | ||
|
|
||
| const SNAPSHOT_URL = 'https://hub.snapshot.org/graphql'; | ||
|
|
||
| export const createSnapshotSubgraphClient = () => { | ||
| // Check if we already have a Snapshot client | ||
| const cachedClient = clientCache.get(SNAPSHOT_URL); | ||
| if (cachedClient) { | ||
| return cachedClient; | ||
| } | ||
|
|
||
| // Create new Snapshot client if not cached | ||
| const client = createClient({ | ||
| url: SNAPSHOT_URL, | ||
| exchanges: [cacheExchange, fetchExchange], | ||
| }); | ||
|
|
||
| // Cache the new client | ||
| clientCache.set(SNAPSHOT_URL, client); | ||
| return client; | ||
| }; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥