Gasless voting UI #2692

DarksightKellar · 2025-01-27T15:14:00Z

Closes ENG-25
Closes ENG-153

DAO settings:

PS: @decentdao/design In DAO settings above, the "propose" button now sits very weirdly.

Create DAO flow

Design (implemented in a previous commit):

Implemented currently:

See this comment

See issue for testing instructions

linear · 2025-01-27T15:14:04Z

ENG-25 Gasless voting when creating DAO - low fidelity UI

cloudflare-workers-and-pages · 2025-01-27T15:15:42Z

Deploying decent-interface with Cloudflare Pages

Latest commit:	`efd973f`
Status:	✅ Deploy successful!
Preview URL:	https://d22099e8.decent-interface.pages.dev
Branch Preview URL:	https://eng-25-gassless-voting-ui.decent-interface.pages.dev

View logs

linear · 2025-01-27T15:41:28Z

ENG-153 Gasless Voting - Add gasless voting preference to DAO settings, Low fidelity UI only

src/components/DaoCreator/constants.ts

src/components/DaoCreator/formComponents/AzoriusGovernance.tsx

src/components/DaoCreator/formComponents/AzoriusTokenDetails.tsx

src/components/DaoCreator/formComponents/Multisig.tsx

src/components/ui/GasslessVotingToggle.tsx

src/i18n/locales/en/daoCreate.json

src/pages/dao/settings/general/SafeGeneralSettingsPage.tsx

…h context. Removed.

Da-Colon

I take it screenshots are not accurate anymore in the description. as DAOCreate doesn't have the address anymore?

src/components/DaoCreator/constants.ts

src/components/ui/GaslessVotingToggle.tsx

src/hooks/useNativeToken.ts

DarksightKellar · 2025-01-29T14:44:46Z

Gonna mark this as draft since there's a number of unresolved points pending input

xanaramoss · 2025-01-31T16:24:56Z

@DarksightKellar The button seems very small and looks weird bellow the divider.
Do we need a button there to propose the changes? I though there was a general button like "save all changes". But I did not work on this screens so I'm a bit lost.

@nicolaus-sherrill will be able to give you more input.

nicolaus-sherrill

The "Propose" button in Settings is a global button for the settings experience and should be anchored to the bottom of the UI. It is pressed when the user finishes a session and pushes their settings and governance updates to a proposal.

…ag and gas tank address from external source of truth

DarksightKellar · 2025-02-04T18:44:37Z

The "Propose" button in Settings is a global button for the settings experience and should be anchored to the bottom of the UI. It is pressed when the user finishes a session and pushes their settings and governance updates to a proposal.

@nicolaus-sherrill

nicolaus-sherrill

@DarksightKellar this looks great for setup. High-fidelity UI is incoming today.

src/components/DaoCreator/formComponents/AzoriusGovernance.tsx

src/components/DaoCreator/formComponents/Multisig.tsx

src/components/ui/GaslessVotingToggle.tsx

Da-Colon · 2025-02-07T15:57:41Z

src/pages/dao/settings/general/SafeGeneralSettingsPage.tsx

+    if (gaslessVotingChanged) {
+      changeTitles.push(t('enableGaslessVoting', { ns: 'proposalMetadata' }));
+
+      // @todo Is KV pairs the place we're storing this flag?


Thats a good question? Probably right?

src/types/fractal.ts

…ToggleDAOCreate` and `GaslessVotingToggleDAOSettings`

DarksightKellar added 4 commits January 27, 2025 14:03

Add GasslessVotingToggleCard

83fa276

Add GasslessVotingToggleDAOSettings

61e24f1

Move GasslessVotingToggle

af5ada3

Add "add gas" button

2db640a

DarksightKellar requested review from mudrila, Da-Colon, adamgall, johnqh and a team and removed request for mudrila and Da-Colon January 27, 2025 15:39

adamgall reviewed Jan 28, 2025

View reviewed changes

DarksightKellar added 4 commits January 29, 2025 11:03

Move feature behing flag

6c86f3e

Include feature for multisig create

f540143

gassless -> gasless 🤦🏾‍♂️

259aa58

cleanup

d168e33

DarksightKellar force-pushed the eng-25-gassless-voting-ui branch from 0b38204 to d168e33 Compare January 29, 2025 11:07

DarksightKellar requested a review from adamgall January 29, 2025 11:10

DarksightKellar added 4 commits January 29, 2025 11:35

Reduce instances of hardcoded demo address to 1

1e623e0

Remove balance prop. Read data from native token

f8afb0d

Balance and address don't make sense for create DAO as there's no suc…

e113bbc

…h context. Removed.

Don't show balance if not loaded

cfb7a1a

DarksightKellar changed the title ~~[Eng-25] Gassless voting UI~~ Gassless voting UI Jan 29, 2025

Da-Colon reviewed Jan 29, 2025

View reviewed changes

src/components/DaoCreator/constants.ts Show resolved Hide resolved

src/components/ui/GaslessVotingToggle.tsx Outdated Show resolved Hide resolved

src/hooks/useNativeToken.ts Outdated Show resolved Hide resolved

DarksightKellar marked this pull request as draft January 29, 2025 14:44

DarksightKellar changed the title ~~Gassless voting UI~~ Gasless voting UI Jan 29, 2025

DarksightKellar added 3 commits January 31, 2025 12:57

Some cleanup

305ebf1

Add gasless supported flag to network config

3094fdf

Merge branch 'develop' into eng-25-gassless-voting-ui

21e4423

DarksightKellar marked this pull request as ready for review January 31, 2025 13:39

DarksightKellar requested a review from Da-Colon January 31, 2025 13:39

nicolaus-sherrill requested changes Jan 31, 2025

View reviewed changes

DarksightKellar added 5 commits February 4, 2025 15:46

Move propose changes button to bottom of page. bugfix

e8e024f

Add updateDAOInfo to useDaoInfoStore, for setting gasless voting fl…

748f9ce

…ag and gas tank address from external source of truth

Remove unused types

a206d50

Add some more placeholder logic to onToggle and add gas button click

5db5d82

DRY

1d54f0b

dont hardcode ETH

bbbe6fe

DarksightKellar requested a review from nicolaus-sherrill February 4, 2025 18:53

Merge branch 'develop' into eng-25-gassless-voting-ui

0a254bb

nicolaus-sherrill approved these changes Feb 6, 2025

View reviewed changes

Da-Colon reviewed Feb 7, 2025

View reviewed changes

DarksightKellar added 4 commits February 10, 2025 15:16

Move gaslessVotingSupported conditional rendering into `GaslessVoting…

d94b010

…ToggleDAOCreate` and `GaslessVotingToggleDAOSettings`

re-arrange some stuff

c044f3b

Move dao gasless state props to subgraphInfo

4f91044

Asked AI to simplify. Boom. Nifty lil thing.

714237a

DarksightKellar requested a review from Da-Colon February 10, 2025 15:28

fix types

efd973f

Da-Colon approved these changes Feb 10, 2025

View reviewed changes

adamgall approved these changes Feb 10, 2025

View reviewed changes

DarksightKellar merged commit 9a74f37 into develop Feb 11, 2025
4 checks passed

DarksightKellar deleted the eng-25-gassless-voting-ui branch February 11, 2025 14:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Gasless voting UI #2692

Gasless voting UI #2692

DarksightKellar commented Jan 27, 2025 •

edited

Loading

linear bot commented Jan 27, 2025

cloudflare-workers-and-pages bot commented Jan 27, 2025 •

edited

Loading

linear bot commented Jan 27, 2025

Da-Colon left a comment

DarksightKellar commented Jan 29, 2025 •

edited

Loading

xanaramoss commented Jan 31, 2025

nicolaus-sherrill left a comment

DarksightKellar commented Feb 4, 2025

nicolaus-sherrill left a comment

Da-Colon Feb 7, 2025

Gasless voting UI #2692

Gasless voting UI #2692

Conversation

DarksightKellar commented Jan 27, 2025 • edited Loading

DAO settings:

Create DAO flow

linear bot commented Jan 27, 2025

cloudflare-workers-and-pages bot commented Jan 27, 2025 • edited Loading

Deploying decent-interface with Cloudflare Pages

linear bot commented Jan 27, 2025

Da-Colon left a comment

Choose a reason for hiding this comment

DarksightKellar commented Jan 29, 2025 • edited Loading

xanaramoss commented Jan 31, 2025

nicolaus-sherrill left a comment

Choose a reason for hiding this comment

DarksightKellar commented Feb 4, 2025

nicolaus-sherrill left a comment

Choose a reason for hiding this comment

Da-Colon Feb 7, 2025

Choose a reason for hiding this comment

DarksightKellar commented Jan 27, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Jan 27, 2025 •

edited

Loading

DarksightKellar commented Jan 29, 2025 •

edited

Loading