Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-71] Role Term 'pending' Showing incorrectly #2690

Merged
merged 6 commits into from
Jan 27, 2025

Conversation

Da-Colon
Copy link
Contributor

Closes ENG-71

I don't have the before shot, but the logic was missing and was missing an update.

localhost_3000_roles_edit_dao=sep_0x908c810A53D634E82FE810407e97C3c9073545c4(Desktop) (1)

@Da-Colon Da-Colon self-assigned this Jan 24, 2025
Copy link

linear bot commented Jan 24, 2025

Copy link

cloudflare-workers-and-pages bot commented Jan 24, 2025

Deploying decent-interface with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4433705
Status: ✅  Deploy successful!
Preview URL: https://efaa2c26.decent-interface.pages.dev
Branch Preview URL: https://eng-71-fix-role-term-pending.decent-interface.pages.dev

View logs

Copy link
Contributor

@DarksightKellar DarksightKellar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A question or two, then can approve

@Da-Colon Da-Colon merged commit c65cd6e into develop Jan 27, 2025
4 checks passed
@Da-Colon Da-Colon deleted the eng-71-fix-role-term-pending-logic branch January 27, 2025 17:21
Copy link

sentry-io bot commented Feb 5, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Cannot read properties of undefined (reading 'nominee') //roles/edit View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants