2127 Disable submit proposal when submitting
#2131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for decent-interface-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
adamgall
approved these changes
Jul 10, 2024
|
shipit |
mudrila
approved these changes
Jul 10, 2024
| @@ -140,7 +140,12 @@ export default function RoleFormCreateProposal({ close }: { close: () => void }) | |||
| > | |||
| {t('cancel', { ns: 'common' })} | |||
| </Button> | |||
| <Button onClick={() => handleSubmit()}>{t('sendAssetsSubmit')}</Button> | |||
| <Button | |||
| onClick={() => handleSubmit()} | |||
There was a problem hiding this comment.
Can't it be just onClick={handleSubmit}?
There was a problem hiding this comment.
Nope. This technically should just work as type="submit" but it for some reason doesn't work. the typing of handleSubmit doesn't allow for it to be formatted that way unfortunately
DarksightKellar
approved these changes
Jul 11, 2024
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2127