Fix(#7401, #7415): resolve visual editing issues #7405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eoneill
reviewed
Feb 13, 2025
| @@ -1,6 +1,5 @@ | |||
| import { vercelStegaEncode } from '@vercel/stega'; | |||
|
|
|||
| import { isImmutableMap, isImmutableList } from './types'; | |||
| import { isImmutableMap, isImmutableList } from 'decap-cms-lib-util/src/types'; | |||
There was a problem hiding this comment.
Looking at this again, I think this will actually have a similar issue. In general, I don't think we should ever use imports that directly reach into <package>/src/.
Possible fixes...
import { ... } from 'decap-cms-lib-util/dist/esm/types'- re-export these methods in
decap-cms-lib-util/src/index.tsandimport { ... } from 'decap-cms-lib-util' - move these
isImmutable*methods intodecap-cms-core, as they aren't used anywhere else currently
There was a problem hiding this comment.
Oh yes, good catch! I moved the type guards to types/immutable.ts in the core package – a file which was already there. I think this is a good fit.
|
Update: I updated the PR to include a fix for #7415 since this is closely related. |
fgnass
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #7401 by moving stega.ts to the core package, thereby getting rid of the circular dependency.
Additional changes:
visualEditingprop to the type declarations.nxanddistin jestTest plan
Use decap-cms-app in an external project.
Checklist
Please add a
xinside each checkbox:A picture of a cute animal (not mandatory but encouraged)
🦦