Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch redshift table size estimation #2703

Merged
merged 1 commit into from
Aug 17, 2020
Merged

patch redshift table size estimation #2703

merged 1 commit into from
Aug 17, 2020

Conversation

vogt4nick
Copy link
Contributor

@vogt4nick vogt4nick commented Aug 14, 2020

resolves #2702

Description

Root cause of #2702 seems to be size in MB is passed to format_bytes which expects amount in bytes. This PR estimates Redshift table size in bytes.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot
Copy link

cla-bot bot commented Aug 14, 2020

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Nick Vogt.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see /~https://github.com/settings/emails

@cla-bot
Copy link

cla-bot bot commented Aug 14, 2020

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin.

CLA has not been signed by users: @vogt4nick

@cla-bot cla-bot bot added the cla:yes label Aug 14, 2020
@vogt4nick vogt4nick changed the title 2702 patch redshift table size estimation patch redshift table size estimation Aug 14, 2020
Copy link
Contributor

@beckjake beckjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thank you for contributing to dbt!

@beckjake beckjake merged commit 4f2acc2 into dbt-labs:dev/marian-anderson Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redshift table size estimates gigabytes as kilobytes.
3 participants