Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 26.0.0 #884

Merged
merged 7 commits into from
Jan 13, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
@@ -1 +1 @@
module.exports = require('visyn_scripts/config/eslintrc.template')({ tsconfigRootDir: __dirname });
module.exports = require('visyn_scripts/config/eslintrc.template')({ tsconfigRootDir: __dirname, optimizeImports: true });
38 changes: 36 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
@@ -1,19 +1,53 @@
name: build
name: Build repository

on:
workflow_dispatch:
inputs:
run_parallel:
description: 'Run jobs in parallel'
required: false
type: boolean
default: true
self_hosted:
description: 'Run on self-hosted runner'
required: false
type: boolean
default: true
cypress:
description: 'Run cypress'
required: false
type: boolean
default: false
playwright:
description: 'Run playwright'
required: false
type: boolean
default: false
playwright_spec_param:
type: string
description: 'Run specific playwright test(s) (optional). Example: landing-page.spec.ts'
required: false
push:
pull_request:
types: [opened, ready_for_review]
pull_request_review:
types: [submitted]

jobs:
build:
if: ${{ github.event_name != 'pull_request_review' || github.event.review.state == 'approved' }}
uses: datavisyn/github-workflows/.github/workflows/build-node-python.yml@main
secrets: inherit
# Boolean inputs are tricky in Github Actions. Their default is not honored in non-workflow-dispatch actions, so setting a default on push is tricky: https://stackoverflow.com/a/73495922
# To get on push true, use !contains(inputs.myInput, 'false')
# To get on push false, use contains(inputs.myInput, 'true')
with:
run_parallel: ${{ !contains(inputs.run_parallel, 'false') }} # true except if box is not checked
runs_on: ${{ (!contains(inputs.self_hosted, 'false') && 'self-hosted') || null }} # self-hosted except if box is not checked
cypress_enable: true
cypress_run_because_flag: ${{ inputs.cypress == true }}
cypress_run_because_flag: ${{ inputs.cypress == true || github.event_name == 'pull_request' || github.event.review.state == 'approved' }}
cypress_runs_on: ${{ (!contains(inputs.self_hosted, 'false') && 'self-hosted') || null }} # self-hosted except if box is not checked
playwright_enable: false
playwright_run_because_flag: ${{ inputs.playwright == true || github.event_name == 'pull_request' || github.event.review.state == 'approved' }}
playwright_spec_param: ${{ inputs.playwright_spec_param }}
playwright_runs_on: ${{ (!contains(inputs.self_hosted, 'false') && 'self-hosted') || null }} # self-hosted except if box is not checked
34 changes: 29 additions & 5 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,32 @@
name: release
name: Create a new release

on:
workflow_dispatch:
inputs:
release_version:
type: string
description: 'The next version to release'
required: true
pull_request:
types: [closed]
branches:
- 'main'

on: workflow_dispatch

jobs:
release:
create_release_pr:
if: ${{ github.event_name == 'workflow_dispatch' }}
uses: datavisyn/github-workflows/.github/workflows/release-source.yml@main
secrets: inherit
secrets: inherit
with:
release_version: ${{ inputs.release_version }}
is_helm_chart: false

post_merge_release:
if: ${{ github.event_name == 'pull_request' && github.event.pull_request.merged == true && startsWith(github.event.pull_request.title, 'Release') }}
uses: datavisyn/github-workflows/.github/workflows/release-post-merge.yml@main
secrets: inherit
with:
pr_title: ${{ github.event.pull_request.title }}
pr_number: ${{ github.event.pull_request.number }}
repository_owner: ${{ github.repository_owner }}
repository_name: ${{ github.event.repository.name }}
12 changes: 10 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,19 @@ documentation:

.PHONY: install ## Install the requirements
install:
pip install -e .
@if [ ! -z "${CI}" ]; then \
uv pip install -e . --system --upgrade; \
else \
uv pip install -e . --upgrade; \
fi

.PHONY: develop ## Set up the development environment
develop:
pip install -e .[develop]
@if [ ! -z "${CI}" ]; then \
uv pip install -e ".[develop]" --system --upgrade; \
else \
uv pip install -e ".[develop]" --upgrade; \
fi

.PHONY: env_encrypt ## Encrypts the current ./<app>/.env
env_encrypt:
Expand Down
2 changes: 2 additions & 0 deletions cypress/component/component-health-check.cy.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import * as React from 'react';

import { VisynAppProvider } from 'visyn_core/app';

import { MainApp } from '../../src/demo/MainApp';
// Load the phovea_registry to ensure all extension points (like locales) are loaded.
import '../../src/phovea_registry';
Expand Down
1 change: 1 addition & 0 deletions cypress/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"compilerOptions": {
"outDir": "./dist",
"sourceMap": false,
"declarationMap": false,
"types": [
"cypress"
]
Expand Down
8 changes: 4 additions & 4 deletions dist/ATDPApplication.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/ATDPApplication.d.ts.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 8 additions & 8 deletions dist/ATDPApplication.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/ATDPApplication.js.map

Large diffs are not rendered by default.

Loading