Skip to content

Commit

Permalink
Remove storybook as it hoists fork-ts-checker-webpack-plugin
Browse files Browse the repository at this point in the history
  • Loading branch information
puehringer committed Feb 25, 2024
1 parent 519271f commit e31b36c
Show file tree
Hide file tree
Showing 11 changed files with 11 additions and 70 deletions.
22 changes: 0 additions & 22 deletions .storybook/main.js

This file was deleted.

15 changes: 0 additions & 15 deletions .storybook/preview.js

This file was deleted.

7 changes: 1 addition & 6 deletions dist/scss/abstracts/_variables.scss

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/scss/components/_view_lineup.scss

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/scss/main.scss

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/scss/vendors/_lineup.scss

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 3 additions & 15 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,9 @@
"predist": "yarn run lint && yarn run test && yarn run build",
"start:fast": "visyn_scripts start --env workspace_mode=single fast=true",
"start": "visyn_scripts start --env workspace_mode=single",
"storybook:build": "NODE_OPTIONS=--max_old_space_size=4096 build-storybook",
"storybook": "NODE_OPTIONS=--max_old_space_size=4096 start-storybook -p 6006",
"test": "visyn_scripts test",
"bundle:dev": "visyn_scripts bundle --mode development --env workspace_mode=single",
"bundle:prod": "visyn_scripts bundle --mode production --env workspace_mode=single"
"webpack:dev": "visyn_scripts build --mode development --env workspace_mode=single",
"webpack:prod": "visyn_scripts build --mode production --env workspace_mode=single"
},
"dependencies": {
"@popperjs/core": "^2.9.3",
Expand Down Expand Up @@ -90,17 +88,7 @@
"devDependencies": {
"@babel/core": "^7.17.7",
"@babel/plugin-transform-typescript": "7.17.12",
"@storybook/addon-actions": "^6.5.16",
"@storybook/addon-essentials": "^6.5.16",
"@storybook/addon-interactions": "^6.5.16",
"@storybook/addon-links": "^6.5.16",
"@storybook/builder-webpack5": "^6.5.16",
"@storybook/manager-webpack5": "^6.5.16",
"@storybook/preset-scss": "^1.0.3",
"@storybook/react": "^6.5.16",
"@storybook/testing-library": "0.0.13",
"cypress": "^11.2.0",
"storybook-addon-swc": "^1.1.9"
"cypress": "^11.2.0"
},
"resolutions": {
"@types/react": "~18.2.0",
Expand Down
7 changes: 1 addition & 6 deletions src/scss/abstracts/_variables.scss
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,6 @@ $annotation_color_hover: #006b90 !default;
$anchor_color: red !default;
$anchor_color_hover: darkred !default;

/* phovea_ui */
$fa-font-path: '@fortawesome/fontawesome-free/webfonts' !default;

$phovea-loading-icon-url: url('../../assets/caleydo_c_anim.svg') !default;
$phovea-loading-icon-size: auto !default;

Expand All @@ -101,8 +98,6 @@ $anchor_color_hover: darkred !default;
$select-data-color: orange !default;
$hover-data-color: #ffc46b !default;

// TODO: Without this, we get "Can't resolve './node_modules/lineupengine/src/styles/lineupengine/src/assets/loading.svg' in '.../workspaces/<repo>'"
// Why do I need to do this? Probably because lineupjs defines $engine_assets and it is resolving it relatively?
$engine_assets: 'lineupengine/src/assets';
$engine_assets: '../assets';
$engine_loading_image: url('#{$engine_assets}/loading.svg') !default;
$engine_loading_static_image: url('#{$engine_assets}/loading_s.svg') !default;
2 changes: 1 addition & 1 deletion src/scss/components/_view_lineup.scss
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
}
}

$lu_assets: "lineupjs/src/assets";
$lu_assets: "../assets";

@at-root {
.tdp-ranking-export-form {
Expand Down
2 changes: 1 addition & 1 deletion src/scss/main.scss
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@import "visyn_core/dist/scss/main.scss";
@import "visyn_core/scss/main.scss";

@import "./abstracts/functions";
@import './abstracts/variables';
Expand Down
2 changes: 1 addition & 1 deletion src/scss/vendors/_lineup.scss
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
$lu_dialog_font_size: 0.9rem !default;
$lu_toolbar_font_size: 0.9rem !default;

$lu_assets: 'lineupjs/src/assets' !default;
$lu_assets: '../assets' !default;
$lu_use_font_awesome: true !default;
// do not include Font Awesome files from LineUp, but use ours instead
$lu_include_font_awesome: false !default;
Expand Down

0 comments on commit e31b36c

Please sign in to comment.