Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: add DART_USE_SYSTEM_GOOGLEBENCHMARK #1904

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Conversation

nim65s
Copy link
Contributor

@nim65s nim65s commented Jan 20, 2025

Hi,

This PR allow use of installed google benchmark instead of downloading it at configure time.


Before creating a pull request

  • Document new methods and classes
  • Format new code files using ClangFormat by running make format
  • Build with -DDART_TREAT_WARNINGS_AS_ERRORS=ON and resolve all the compile warnings

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change
  • Add Python bindings for new methods and classes

@jslee02 jslee02 added this to the DART 6.16.0 milestone Jan 20, 2025
@jslee02
Copy link
Member

jslee02 commented Jan 20, 2025

I confirmed that this works with the option enabled and disabled. Thanks for implementing it!

@jslee02 jslee02 merged commit c18c48a into dartsim:main Jan 20, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants