-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[native_assets_builder] Support pub workspaces #1911
Conversation
PR HealthBreaking changes ✔️
Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
|
Friendly ping @HosseinYousefi @mosuem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Somehow missed it from my inbox. Thanks for the ping!
Merci! 🙏 |
This CL goes part of the way to support pub workspaces with native assets. This CL makes the `runPackageName` explicit in every invocation. This ensures not too many native assets are built. Moreover, this CL also makes `packageLayout` explicit, ensuring the right packages config file is used. A follow up PR should fix the checks w.r.t. the experiment not being enabled. For more info see: dart-lang/native#1911 TEST=pkg/dartdev/test/native Change-Id: I3c3123526e320abb8bb094116e58bb4340c4c052 Cq-Include-Trybots: luci.dart.try:pkg-linux-debug-try,pkg-linux-release-arm64-try,pkg-linux-release-try,pkg-mac-release-arm64-try,pkg-mac-release-try,pkg-win-release-arm64-try,pkg-win-release-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/405141 Commit-Queue: Daco Harkes <dacoharkes@google.com> Reviewed-by: Ben Konyi <bkonyi@google.com>
Bug: #1905
.dart_tool/package_config.json
is possibly in a ancestor directoryrunPackageName
argument is now required for build/link hooks.Doesn't yet address:
runPackageName
argument should be required for "if there are packages with native assets", the native assets experiment only has to be enabled if a dependency has a hook. (requires a bigger refactoring)