-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[native_toolchain_c] Support Clang on Windows #1893
Conversation
PR HealthBreaking changes ✔️
Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
|
selectOptimizationLevel = | ||
(selectOptimizationLevel + 1) % optimizationLevels.length; | ||
final buildMode = BuildMode.values[selectBuildMode]; | ||
selectBuildMode = (selectBuildMode + 1) % BuildMode.values.length; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this some kind of fuzzy testing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heh, it would be fuzz testing if we would randomize the params and run it nightly. Now it's a poor mans combination of trying to cover some combination of params 😄
Thanks @mkustermann and @mosuem ! 🙏 |
Bug: #1892
It seems that both Clang via /~https://github.com/llvm/llvm-project/releases/tag/llvmorg-19.1.0, and Clang via the MSVC installer come with batteries included and link to the windows headers (added an use of
wprintf
).(The Clang-for-Windows on the Dart CI does not come with batteries included: see #1892 (comment).)
Does not add support for arm64 (neither msvc nor clang): #170