Implement Configuration for Connecting to IPFS Private Network (pnet) #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariusc93
reviewed
Feb 28, 2025
dariusc93
reviewed
Mar 1, 2025
Cargo.toml
Outdated
| @@ -134,6 +134,7 @@ tracing-futures = { workspace = true } | |||
| unsigned-varint.workspace = true | |||
| web-time.workspace = true | |||
| zeroize.workspace = true | |||
| libp2p = { workspace = true, features = ["pnet"] } | |||
There was a problem hiding this comment.
Can we add this feature on libp2p under [target.'cfg(not(target_arch = "wasm32"))'.dependencies]? I think we could also add it under the dependencies targeting wasm32, no? I never tried pnet on wasm targets so I wouldnt know for sure so we could probably exclude it from that section for now.
What are your thoughts on that?
There was a problem hiding this comment.
You're right. We can add the feature under [target.'cfg(not(target_arch = "wasm32"))'.dependencies] first. Since we're uncertain about its performance on wasm32 targets, excluding it from that section for now is a practical approach.
dariusc93
reviewed
Mar 1, 2025
Co-authored-by: Darius Clark <dariusc93@users.noreply.github.com>
dariusc93
reviewed
Mar 1, 2025
|
I'm new to this. Thanks a ton for the guidance! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to add functionality to the existing codebase that enables the configuration of connections to an IPFS private network (pnet). By implementing this feature, users will have the ability to interact with a private and potentially more secure IPFS network environment, which is crucial for applications that require data privacy, restricted access, or operation within a closed - group infrastructure.