fix #13362: Misra report on command line #7096
Conversation
ludviggunne
force-pushed
the
13362
branch
3 times, most recently
from
70c91e1 to
aed1653
Compare
|
@firewave I seem to be missing something with the CMake build, could you point me in the right direction? As I understand it all the lib/ sources should be available in the GUI. /~https://github.com/danmar/cppcheck/actions/runs/12446323642/job/34748592068?pr=7096#step:12:141 |
Nevermind, found the problem. |
ludviggunne
force-pushed
the
13362
branch
2 times, most recently
from
d4e9dec to
d337781
Compare
lib/checkers.cpp
Outdated
| @@ -2096,3 +2097,183 @@ std::vector<checkers::Info> checkers::certCppInfo{ | |||
| {"MSC53-CPP", "L2"}, | |||
| {"MSC54-CPP", "L2"}, | |||
| }; | |||
|
|
|||
| namespace checkers { | |||
There was a problem hiding this comment.
this file is autogenerated so don't change this file. Next time I autogenerate this file to make it uptodate this code will be removed it will be a mess.
There was a problem hiding this comment.
Do you have a preference for which file these functions should be in?
There was a problem hiding this comment.
hmm ideally I think it would be better if this information was dynamic. cppcheck could fetch the list of checkers from premiumaddon at runtime. but that does not feel like a refactoring you should make in this PR.
There was a problem hiding this comment.
Hm, I'm not sure if we're talking about the same functions. The functions I added don't depend on the premiumCheckers map. Or am I missing something?
There was a problem hiding this comment.
Do you have a preference for which file these functions should be in?
I suggest that it is added in the ErrorLogger.
There was a problem hiding this comment.
I've been working on moving this logic to ErrorLogger, unfortunatley it seems to be necessary to drag in a bunch of dependencies for the gui tests. Maybe these functions could be in its own file/some other file?
This reverts commit 24485853ad1cfa4d4a43aa1036fe9491e27b056f.
ludviggunne
force-pushed
the
13362
branch
3 times, most recently
from
2ecfb14 to
e997eb9
Compare
WIP. Will add tests and HTML output.