Remove enum prefixes

src/betterproto/compile/naming.py

@@ -1,3 +1,5 @@
+from typing import Iterable, List
+
 from betterproto import casing
 
 
@@ -11,3 +13,19 @@ def pythonize_field_name(name: str) -> str:
 
 def pythonize_method_name(name: str) -> str:
     return casing.safe_snake_case(name)
+
+
+def pythonize_enum_member_names(names: Iterable[str]) -> List[str]:
+    """Removes any of the same characters from an Enum member's names."""
+
+    def find_max_prefix_len() -> int:
+        for max_prefix_len, chars in enumerate(tuple(zip(*map(tuple, names)))):
+            previous_char = chars[0][0]
+            for char in chars:
+                if previous_char != char:
+                    return max_prefix_len
+        return 0
+
+    max_prefix_len = find_max_prefix_len()
+
+    return [casing.sanitize_name(name[max_prefix_len:]) for name in names]

src/betterproto/plugin/models.py

@@ -36,10 +36,10 @@
 
 import betterproto
 
-from ..casing import sanitize_name
 from ..compile.importing import get_type_reference, parse_source_type_name
 from ..compile.naming import (
     pythonize_class_name,
+    pythonize_enum_member_names,
     pythonize_field_name,
     pythonize_method_name,
 )
@@ -522,15 +522,20 @@ class EnumEntry:
 
     def __post_init__(self) -> None:
         # Get entries/allowed values for this Enum
+        member_names = pythonize_enum_member_names(
+            [entry_proto_value.name for entry_proto_value in self.proto_obj.value]
+        )
         self.entries = [
             self.EnumEntry(
-                name=sanitize_name(entry_proto_value.name),
+                name=member_name,
                 value=entry_proto_value.number,
                 comment=get_comment(
                     proto_file=self.proto_file, path=self.path + [2, entry_number]
                 ),
             )
-            for entry_number, entry_proto_value in enumerate(self.proto_obj.value)
+            for member_name, (entry_number, entry_proto_value) in zip(
+                member_names, enumerate(self.proto_obj.value)
+            )
         ]
         super().__post_init__()  # call MessageCompiler __post_init__
 

tests/inputs/enum/enum.proto

@@ -13,3 +13,10 @@ enum Choice {
   FOUR = 4;
   THREE = 3;
 }
+
+// A "C" like enum with the enum name prefixed onto members, these should be stripped
+enum ArithmeticOperator {
+    ARITHMETIC_OPERATOR_NONE = 0;
+    ARITHMETIC_OPERATOR_PLUS = 1;
+    ARITHMETIC_OPERATOR_MINUS = 2;
+}

tests/inputs/enum/test_enum.py

@@ -1,7 +1,4 @@
-from tests.output_betterproto.enum import (
-    Test,
-    Choice,
-)
+from tests.output_betterproto.enum import ArithmeticOperator, Test, Choice
 
 
 def test_enum_set_and_get():
@@ -82,3 +79,8 @@ def enum_generator():
         yield Choice.THREE
 
     assert Test(choices=enum_generator()).to_dict()["choices"] == ["ONE", "THREE"]
+
+
+def test_renamed_enum_members():
+    for member in ArithmeticOperator:
+        assert member.name in ("NONE", "PLUS", "MINUS")