Feature: Add SimpBMS battery support #917
Merged
+155
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalathegreat
requested changes
Feb 25, 2025
|
I've addressed the comments :D |
|
@jamiejones85 Code formatting fails, best to run the pre-commit hook, explained here how: /~https://github.com/dalathegreat/Battery-Emulator/blob/main/CONTRIBUTING.md#code-formatting |
|
Updated after running pre-commit now. |
|
Still failing, try running |
Sorry, idiot here forgot to commit all files. Should be good now. |
|
Massive thanks @jamiejones85 ! Will merge this now! Oh, and I also created a SimpBMS Wiki page, feel free to add to it! /~https://github.com/dalathegreat/Battery-Emulator/wiki/Battery:-SimpBMS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings in support to use battery packs with the SimpBMS.