Feedback from PR, removing code that's not needed.

dalathegreat · Feb 25, 2025 · 916d406 · 916d406
1 parent 10b85f3
commit 916d406
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 16 deletions.
diff --git a/Software/src/battery/SIMPBMS-BATTERY.cpp b/Software/src/battery/SIMPBMS-BATTERY.cpp
@@ -26,7 +26,7 @@ static uint8_t cells_in_series = 0;
 static uint8_t voltage_level = 0;
 static uint8_t ah_total = 0;
 static uint8_t SOC = 0;
-static uint8_t SOH = 0;
+static uint8_t SOH = 99;
 static uint8_t charge_forbidden = 0;
 static uint8_t discharge_forbidden = 0;
 static uint16_t cellvoltages_mV[SIMPBMS_MAX_CELLS] = {0};
@@ -118,11 +118,6 @@ void handle_incoming_can_frame_battery(CAN_frame rx_frame) {
 }
 
 void transmit_can_battery() {
-  unsigned long currentMillis = millis();
-  // Send 1s CAN Message
-  if (currentMillis - previousMillis1000 >= INTERVAL_1_S) {
-    previousMillis1000 = currentMillis;
-  }
 }
 
 void setup_battery(void) {  // Performs one time setup at startup

diff --git a/Software/src/devboard/webserver/advanced_battery_html.cpp b/Software/src/devboard/webserver/advanced_battery_html.cpp
@@ -481,15 +481,6 @@ String advanced_battery_processor(const String& var) {
     content += "<h4>Temperature sensor 10: " + String(datalayer_extended.bydAtto3.battery_temperatures[9]) + "</h4>";
 #endif  //BYD_ATTO_3_BATTERY
 
-#ifdef SIMPBMS_BATTERY
-    content += "<h4>Max Design Voltage: " + String(datalayer.battery.info.max_design_voltage_dV) + " dV</h4>";
-    content += "<h4>Min Design Voltage: " + String(datalayer.battery.info.min_design_voltage_dV) + " dV</h4>";
-    content += "<h4>Max Charge Current: " + String(datalayer.battery.status.max_charge_current_dA) + " dA</h4>";
-    content += "<h4>Max Discharge Current: " + String(datalayer.battery.status.max_discharge_current_dA) + " dA</h4>";
-    content += "<h4>Pack Voltage: " + String(  datalayer.battery.status.voltage_dV) + " dV</h4>";
-    content += "<h4>Reported Current: " + String(  datalayer.battery.status.current_dA) + " dA</h4>";
-    content += "<h4>Series Cells: " + String(datalayer.battery.info.number_of_cells) + " dV</h4>";
-#endif
 #ifdef TESLA_BATTERY
     float beginning_of_life = static_cast<float>(datalayer_extended.tesla.battery_beginning_of_life);
     float battTempPct = static_cast<float>(datalayer_extended.tesla.battery_battTempPct) * 0.4;
@@ -1424,7 +1415,7 @@ String advanced_battery_processor(const String& var) {
     !defined(TESLA_BATTERY) && !defined(NISSAN_LEAF_BATTERY) && !defined(BMW_I3_BATTERY) &&          \
     !defined(BYD_ATTO_3_BATTERY) && !defined(RENAULT_ZOE_GEN2_BATTERY) && !defined(CELLPOWER_BMS) && \
     !defined(MEB_BATTERY) && !defined(VOLVO_SPA_BATTERY) && !defined(VOLVO_SPA_HYBRID_BATTERY) &&    \
-    !defined(KIA_HYUNDAI_64_BATTERY) && !defined(SIMPBMS_BATTERY)  //Only the listed types have extra info
+    !defined(KIA_HYUNDAI_64_BATTERY) //Only the listed types have extra info
     content += "No extra information available for this battery type";
 #endif