This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
Add ability to run with DC/OS Enterprise strict security mode #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DC/OS Enterprise Support
This is in support of #86
On DC/OS Enterprise, one can run with a strict security mode. In this environment, DC/OS schedulers cannot talk directly to Mesos masters on port 5050, but must rather go through DC/OS adminrouter. This requires 2 things not previously present in mesos-rxjava
I did not do anything additionally to support enterprise other than the 2 items above. I took care of actually authenticating a service account and refreshing the token within my scheduler.
NOTE: I am aware that I need to add some tests and comments to make this PR complete. I wanted to at least get this out there for initial review as I know the project has changed ownership. I can follow any new guidance on formatting, docs, tests, etc.
Thanks!