feat: supported type of vue@2.7+ #28818

baboon-king · 2024-01-29T11:36:28Z

Closes Support Vue 2.7.16 #28591

Additional details

Add support for vue@2.7+ types.

Steps to test

none

How has the user experience changed?

Better type support in Vue@2.7

PR Tasks

Have tests been added/updated?
Has a PR for user-facing changes been opened in cypress-documentation?
Have API changes been updated in the type definitions?

CLAassistant · 2024-01-29T11:36:35Z

All committers have signed the CLA.

cypress-app-bot · 2024-01-29T11:36:40Z

Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.

jennifer-shehane · 2024-01-29T15:45:19Z

@baboon-king Looks like there's an error being thrown in our build job.

baboon-king · 2024-01-30T01:59:21Z

@baboon-king Looks like there's an error being thrown in our build job.

All right. Let's me look look!

baboon-king · 2024-01-30T03:55:14Z

@jennifer-shehane

After my examination.

TBH.
This is a problem that comes from upstream. In "umd.d.ts" he imported an unexported type.
import: /~https://github.com/vuejs/vue/blob/main/types/umd.d.ts#L3
unexported: /~https://github.com/vuejs/vue/blob/main/types/options.d.ts#L163
But /~https://github.com/vuejs/vue?tab=readme-ov-file#vue-2-has-reached-end-of-life lol.

So. I need more time to try and fix it.

baboon-king · 2024-02-01T07:38:13Z

more info
https://rollupjs.org/troubleshooting/#error-name-is-not-exported-by-module

baboon-king · 2024-02-02T02:10:59Z

@jennifer-shehane Hi！
Excuse me.

In a nutshell, this is because rollup-plugin-dts has respectExternal: true.
This option is false by default, do you know why you set respectExternal to true.
For npm/vue2 build tasks can I turn off this option, or is it possible?

All external dependencies from node_modules are automatically excluded from bundling. This can be overridden using the respectExternal setting, but it is generally not recommended. While rollup of external @types generally works, it is not recommended.
/~https://github.com/Swatinem/rollup-plugin-dts?tab=readme-ov-file#what-to-expect

jennifer-shehane · 2024-02-02T14:29:14Z

@baboon-king I don't recall the context on that one.

baboon-king · 2024-02-19T01:48:40Z

@baboon-king I don't recall the context on that one.

it's Ok!.
Can you review my last commit. it's fixed #28818 (comment)

baboon-king · 2024-02-21T08:19:55Z

Hi! @jennifer-shehane

The branch has been rebase , it's clean.

AtofStryker · 2024-02-28T22:39:29Z

npm/vue2/rollup.config.mjs

@@ -3,6 +3,9 @@ import json from '@rollup/plugin-json'
 import replace from '@rollup/plugin-replace'

 const config = {
+  dtsOptions: {
+    respectExternal: false


was the issue that were were rolling up the vue .d.ts files from 2.6.12 and that was causing issues?

No, the issue is not related to rolling up the Vue .d.ts files from 2.6.12. This problem occurs in versions "2.7+" instead.

it sounds like we were bundling the declaration types previously which sounded like it caused a collision. Would this change use the declaration files for whatever version of vue2 is installed?

This won't affect Vue 2. In most cases, this option (respectExternal) doesn't need to be enabled, at least not for Vue as Vue itself already includes its own types. The documentation of rollup-plugin-dts also specifies that this option is disabled by default.

The main issue is that after upgrading to Vue 2.7+, the respectExternal option of rollup-plugin-dts was causing the npm/vue2 build task to fail. That's why I disabled this option for npm/vue2.

AtofStryker

@baboon-king can you help me reproduce the type error you were seeing in vue 2.7.16? I created a reproduction repository here but I can't seem to produce a type error under test. Is there something I am missing or forgetting to do here?

baboon-king · 2024-03-01T16:49:14Z

@baboon-king can you help me reproduce the type error you were seeing in vue 2.7.16? I created a reproduction repository here but I can't seem to produce a type error under test. Is there something I am missing or forgetting to do here?

@AtofStryker see here.

I created a reproduction case here.
/~https://github.com/baboon-king/typescript-cypress-issue-28591
For Terminal

pnpm install
pnpm run type-check

For vscode

Enable the Vue.vscode-typescript-vue-plugin plugin.
Look at lines 5 and 9 of HelloWorld.cy.ts.

AtofStryker

The current method of passing in dtsOptions causes warnings in the build. I recommended a work around to at least avoid this

npm/mount-utils/create-rollup-entry.mjs

npm/vue2/rollup.config.mjs

baboon-king

right！MVP

@AtofStryker
I think it's great, but do I need to review your changes?

AtofStryker · 2024-03-04T13:38:33Z

right！MVP

@AtofStryker I think it's great, but do I need to review your changes?

@baboon-king currently these are just suggestions in the review, which you should be able to apply and test out!

baboon-king · 2024-03-05T05:50:14Z

right！MVP
@AtofStryker I think it's great, but do I need to review your changes?

@baboon-king currently these are just suggestions in the review, which you should be able to apply and test out!

Ok, I see.
And
I've applied and tested it.
at latest commit

AtofStryker

This seems correct based on /~https://github.com/vuejs/vue/blob/main/CHANGELOG.md#typescript-changes. Though it does feel weird that v3 types would live inside an installed version of vue@2. Tested and things seem appropriate on my end

npm/vue2/rollup.config.mjs

Co-authored-by: Bill Glesias <bglesias@gmail.com>

cypress-bot · 2024-03-13T17:27:15Z

Released in 13.7.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.7.0, please open a new issue.

baboon-king mentioned this pull request Jan 30, 2024

Update deps for Vue 2.7 vuejs/create-vue#413

Closed

20 tasks

baboon-king force-pushed the develop branch from aea2f74 to 7351742 Compare February 2, 2024 02:12

baboon-king closed this Feb 2, 2024

baboon-king force-pushed the develop branch from 1eea4f2 to f741635 Compare February 2, 2024 02:13

baboon-king reopened this Feb 2, 2024

baboon-king force-pushed the develop branch from 1ea0f91 to fe17a56 Compare February 2, 2024 03:10

jennifer-shehane assigned baboon-king Feb 19, 2024

baboon-king removed their assignment Feb 20, 2024

baboon-king force-pushed the develop branch from 1dffc49 to 3a0c52c Compare February 21, 2024 08:17

baboon-king force-pushed the develop branch 3 times, most recently from 5be098a to a959256 Compare February 25, 2024 14:30

mschile requested review from mschile and AtofStryker February 27, 2024 16:22

baboon-king force-pushed the develop branch from a959256 to 986a471 Compare February 28, 2024 08:53

AtofStryker reviewed Feb 28, 2024

View reviewed changes

baboon-king force-pushed the develop branch from 986a471 to e84be77 Compare February 28, 2024 23:55

AtofStryker self-requested a review February 29, 2024 22:06

baboon-king force-pushed the develop branch from e84be77 to 41f61ef Compare March 1, 2024 00:26

AtofStryker reviewed Mar 1, 2024

View reviewed changes

jennifer-shehane requested a review from AtofStryker March 1, 2024 18:15

AtofStryker requested changes Mar 1, 2024

View reviewed changes

baboon-king force-pushed the develop branch 2 times, most recently from fce145c to fb32750 Compare March 2, 2024 03:19

baboon-king commented Mar 2, 2024

View reviewed changes

baboon-king force-pushed the develop branch from fb32750 to da57923 Compare March 5, 2024 05:16

baboon-king force-pushed the develop branch from 3e30e44 to 9ba8a32 Compare March 5, 2024 06:08

jennifer-shehane requested a review from AtofStryker March 5, 2024 16:19

baboon-king force-pushed the develop branch from b4c1cd5 to 5483998 Compare March 6, 2024 01:45

AtofStryker approved these changes Mar 6, 2024

View reviewed changes

npm/vue2/rollup.config.mjs Outdated Show resolved Hide resolved

baboon-king force-pushed the develop branch 2 times, most recently from b7d8992 to 8675d4c Compare March 8, 2024 07:14

baboon-king and others added 3 commits March 9, 2024 13:10

feat: supported type of vue@2.7+

55fbf38

chore[build]: respectExternal back to false for vue2 in dts

26fa059

更新 rollup.config.mjs

6f8f349

Co-authored-by: Bill Glesias <bglesias@gmail.com>

baboon-king force-pushed the develop branch from 8675d4c to 6f8f349 Compare March 9, 2024 05:10

mschile added 3 commits March 11, 2024 14:20

Merge branch 'develop' into develop

d613161

updating changelog

b223f19

updating link

ebccafd

mschile approved these changes Mar 11, 2024

View reviewed changes

jennifer-shehane merged commit 854a649 into cypress-io:develop Mar 12, 2024
67 checks passed

cypress-bot bot locked as resolved and limited conversation to collaborators Mar 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: supported type of vue@2.7+ #28818

feat: supported type of vue@2.7+ #28818

baboon-king commented Jan 29, 2024 •

edited by mschile

Loading

CLAassistant commented Jan 29, 2024 •

edited

Loading

cypress-app-bot commented Jan 29, 2024

jennifer-shehane commented Jan 29, 2024

baboon-king commented Jan 30, 2024

baboon-king commented Jan 30, 2024

baboon-king commented Feb 1, 2024

baboon-king commented Feb 2, 2024 •

edited

Loading

jennifer-shehane commented Feb 2, 2024

baboon-king commented Feb 19, 2024

baboon-king commented Feb 21, 2024

AtofStryker Feb 28, 2024

baboon-king Feb 29, 2024

AtofStryker Feb 29, 2024

baboon-king Mar 1, 2024

AtofStryker left a comment

baboon-king commented Mar 1, 2024 •

edited

Loading

AtofStryker left a comment

baboon-king left a comment •

edited

Loading

AtofStryker commented Mar 4, 2024

baboon-king commented Mar 5, 2024

AtofStryker left a comment

cypress-bot bot commented Mar 13, 2024

feat: supported type of vue@2.7+ #28818

feat: supported type of vue@2.7+ #28818

Conversation

baboon-king commented Jan 29, 2024 • edited by mschile Loading

Additional details

Steps to test

How has the user experience changed?

PR Tasks

CLAassistant commented Jan 29, 2024 • edited Loading

cypress-app-bot commented Jan 29, 2024

jennifer-shehane commented Jan 29, 2024

baboon-king commented Jan 30, 2024

baboon-king commented Jan 30, 2024

baboon-king commented Feb 1, 2024

baboon-king commented Feb 2, 2024 • edited Loading

jennifer-shehane commented Feb 2, 2024

baboon-king commented Feb 19, 2024

baboon-king commented Feb 21, 2024

AtofStryker Feb 28, 2024

Choose a reason for hiding this comment

baboon-king Feb 29, 2024

Choose a reason for hiding this comment

AtofStryker Feb 29, 2024

Choose a reason for hiding this comment

baboon-king Mar 1, 2024

Choose a reason for hiding this comment

AtofStryker left a comment

Choose a reason for hiding this comment

baboon-king commented Mar 1, 2024 • edited Loading

AtofStryker left a comment

Choose a reason for hiding this comment

baboon-king left a comment • edited Loading

Choose a reason for hiding this comment

AtofStryker commented Mar 4, 2024

baboon-king commented Mar 5, 2024

AtofStryker left a comment

Choose a reason for hiding this comment

cypress-bot bot commented Mar 13, 2024

baboon-king commented Jan 29, 2024 •

edited by mschile

Loading

CLAassistant commented Jan 29, 2024 •

edited

Loading

baboon-king commented Feb 2, 2024 •

edited

Loading

baboon-king commented Mar 1, 2024 •

edited

Loading

baboon-king left a comment •

edited

Loading