Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved to #27911 #27150

Closed
wants to merge 99 commits into from
Closed
Changes from 6 commits
Commits
Show all changes
99 commits
Select commit Hold shift + click to select a range
6b0a30c
feat: ability to specify the default running browser in cypress config
alexsch01 Jun 27, 2023
6335c53
variable name changes
alexsch01 Jun 27, 2023
8861eae
oops
alexsch01 Jun 27, 2023
8f1c3bc
prevent error when config doesn't exist
alexsch01 Jun 27, 2023
de2fb5f
fixed now
alexsch01 Jun 27, 2023
8770861
getting the cypress.config.js properly
alexsch01 Jun 27, 2023
2f5f10b
browser -> defaultBrowser
alexsch01 Jun 27, 2023
e1e72c1
add defaultBrowser type
alexsch01 Jun 27, 2023
ff75d39
remove not needed parts
alexsch01 Jun 28, 2023
b61f43a
fix for cypress.config.ts
alexsch01 Jun 28, 2023
ef745da
Update cli.js
alexsch01 Jun 28, 2023
1f04fbe
Merge branch 'develop' into default-browser-config
alexsch01 Jun 28, 2023
d91a9f4
Add systemtest: default-browser-config
alexsch01 Jun 29, 2023
0e433fe
temporary changelog
alexsch01 Jun 29, 2023
dd8f70c
Update CHANGELOG.md
alexsch01 Jun 29, 2023
0c502df
Update CHANGELOG.md
alexsch01 Jun 29, 2023
2f333b1
Merge branch 'cypress-io:develop' into default-browser-config
alexsch01 Jun 29, 2023
8cc35f5
Update cli.js
alexsch01 Jun 30, 2023
531c918
fix "-b" override
alexsch01 Jun 30, 2023
6de2752
method won't work for typescript config
alexsch01 Jun 30, 2023
e60534f
"defaultBrowser" -> "browser"
alexsch01 Jul 7, 2023
d013371
Revert CLI changes
alexsch01 Jul 11, 2023
a2c2b83
LETS GO
alexsch01 Jul 11, 2023
8426e3f
Update ProjectLifecycleManager.ts
alexsch01 Jul 11, 2023
90c8da2
isRunMode instead of going through config
alexsch01 Jul 11, 2023
6253f77
oops
alexsch01 Jul 11, 2023
f7524f3
Merge branch 'develop' into default-browser-config
lmiller1990 Jul 12, 2023
66b284d
remove browser RuntimeServerConfigOptions option
alexsch01 Jul 12, 2023
a8a8223
Make logic more clear
alexsch01 Jul 12, 2023
6688398
Update CHANGELOG.md
alexsch01 Jul 12, 2023
9e9a161
Update CHANGELOG.md
alexsch01 Jul 12, 2023
5a95d87
move browsers variable since unused above
alexsch01 Jul 14, 2023
13856b6
Update ProjectLifecycleManager.ts
alexsch01 Jul 14, 2023
6d57b65
add isBrowserGivenByCLI mode option
alexsch01 Jul 14, 2023
2736c5e
fix cypress open error for specific browserLaunch edge case
alexsch01 Jul 17, 2023
9823713
Update ProjectLifecycleManager.ts
alexsch01 Jul 17, 2023
c423b84
Back to default browser (#4)
alexsch01 Jul 18, 2023
3e47dae
Add to packages/config/src/options.ts
alexsch01 Jul 18, 2023
75ff26f
use browser instead of defaultBrowser
lmiller1990 Jul 20, 2023
97f4672
update tests
lmiller1990 Jul 20, 2023
f317b1c
merge develop
lmiller1990 Jul 20, 2023
996a728
Update ProjectLifecycleManager.ts
alexsch01 Jul 27, 2023
83ad754
Update index.ts
alexsch01 Jul 27, 2023
23c9c71
Update spec.cy.js
alexsch01 Jul 27, 2023
3c754c8
make alphabetical
alexsch01 Jul 27, 2023
bc3da51
Revert workaround 1
alexsch01 Jul 28, 2023
20d68e7
Revert workaround 2
alexsch01 Jul 29, 2023
475b51a
Remove browser config option for packages/config/src/options.ts
alexsch01 Jul 29, 2023
d51e789
Merge branch 'develop' into default-browser-config
jordanpowell88 Aug 2, 2023
938c4e6
refactor and add validation
lmiller1990 Aug 8, 2023
9be9ce4
merge in dev
lmiller1990 Aug 8, 2023
60193aa
fix ts build
alexsch01 Aug 8, 2023
817cc09
Update ProjectLifecycleManager.ts
alexsch01 Aug 9, 2023
7e021a6
Update coreDataShape.ts
alexsch01 Aug 9, 2023
442e41c
Update index.ts
alexsch01 Aug 9, 2023
12fc076
Update modeOptions.ts
alexsch01 Aug 9, 2023
72f590a
Merge branch 'develop' into default-browser-config
jennifer-shehane Aug 15, 2023
137fadf
fix ts
lmiller1990 Aug 16, 2023
7a77867
remove unused test project
lmiller1990 Aug 16, 2023
20fc144
fix tests
lmiller1990 Aug 16, 2023
9cba663
update test
lmiller1990 Aug 17, 2023
d7cb149
fix test
lmiller1990 Aug 17, 2023
850848c
tests
lmiller1990 Aug 17, 2023
76e194d
fix ts
alexsch01 Aug 18, 2023
da35999
Merge branch 'develop' into default-browser-config
lmiller1990 Aug 18, 2023
fe64677
Merge branch 'develop' into default-browser-config
jennifer-shehane Aug 18, 2023
344f701
WIP fix
alexsch01 Aug 24, 2023
905b6d5
oops for WIP fix
alexsch01 Aug 24, 2023
4b354dd
more fixes to WIP
alexsch01 Aug 24, 2023
acc024e
Update BrowserActions.ts
alexsch01 Aug 24, 2023
88a6390
huh
alexsch01 Aug 24, 2023
5c6c43b
Merge branch 'develop' into default-browser-config
lmiller1990 Aug 24, 2023
8c26200
make unit-tests pass
alexsch01 Aug 24, 2023
0dfe305
remove trailing whitespace
alexsch01 Aug 25, 2023
59e620b
Merge branch 'develop' into default-browser-config
lmiller1990 Aug 28, 2023
c774f92
fix lint
lmiller1990 Aug 29, 2023
04342e8
lit
lmiller1990 Aug 29, 2023
fa8025b
tests
lmiller1990 Aug 29, 2023
b1bc084
Merge branch 'develop' into default-browser-config
alexsch01 Aug 29, 2023
a34b895
Update config.ts
alexsch01 Aug 29, 2023
e1f535d
Merge branch 'develop' into default-browser-config
alexsch01 Aug 29, 2023
00d6f7c
Merge branch 'develop' into default-browser-config
lmiller1990 Aug 30, 2023
a918d9f
Merge branch 'develop' into default-browser-config
jennifer-shehane Aug 31, 2023
16a194e
Merge branch 'develop' into default-browser-config
alexsch01 Sep 5, 2023
8607b64
reorder browser in snapshot results spec
alexsch01 Sep 11, 2023
04a758a
Merge branch 'develop' into default-browser-config
alexsch01 Sep 11, 2023
a2fa2c2
Merge branch 'develop' into default-browser-config
jennifer-shehane Sep 12, 2023
7b0b264
Merge branch 'develop' into default-browser-config
alexsch01 Sep 19, 2023
a5cb3d9
chore: go back to defaultBrowser (#6)
alexsch01 Sep 22, 2023
f5cfb22
isBrowserGivenByCli
alexsch01 Sep 22, 2023
7b6aaab
oops
alexsch01 Sep 22, 2023
c9ba172
Update index.ts
alexsch01 Sep 22, 2023
b91e7df
finally done
alexsch01 Sep 22, 2023
af58fea
Merge branch 'develop' into default-browser-config
alexsch01 Sep 22, 2023
21ad307
Update CHANGELOG.md
alexsch01 Sep 22, 2023
009515d
Update CHANGELOG.md
alexsch01 Sep 22, 2023
4e95544
Update CHANGELOG.md
alexsch01 Sep 22, 2023
ae6a729
Update CHANGELOG.md
alexsch01 Sep 22, 2023
2a57a74
Merge branch 'develop' into default-browser-config
alexsch01 Sep 26, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions cli/lib/cli.js
Original file line number Diff line number Diff line change
Expand Up @@ -666,6 +666,16 @@ module.exports = {

debug('program parsing arguments')

const PATH_TO_CONFIG = require('path').join(process.cwd(), 'cypress.config.js')
if (require('./fs').existsSync(PATH_TO_CONFIG)) {
const CONFIG_BROWSER = require(PATH_TO_CONFIG).browser

if(!args.includes('--browser') && CONFIG_BROWSER) {
args.push('--browser')
args.push(CONFIG_BROWSER)
}
}

return program.parse(args)
},
}
Expand Down