Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update Chrome renderer crash to be more terse and up to date #26597

Merged
merged 3 commits into from
May 1, 2023
Merged

fix: Update Chrome renderer crash to be more terse and up to date #26597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e531eb6
Update Chrome renderer crash to be more terse and up to date
jennifer-shehane Apr 26, 2023
f1ba964
updated snapshots
mschile May 1, 2023
aeb4067
Merge branch 'develop' into chrome-renderer-crash-error-update
mschile May 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cli/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ _Released 05/09/2023 (PENDING)_
**Bugfixes:**

- Fixed an issue in Electron where devtools gets out of sync with the DOM occasionally. Addresses [#15932](/~https://github.com/cypress-io/cypress/issues/15932).
- Updated the Chromium renderer process crash message to be more terse. Addressed in [#26597](/~https://github.com/cypress-io/cypress/pull/26597).

## 12.11.0

Expand Down
22 changes: 7 additions & 15 deletions packages/errors/__snapshot-html__/RENDERER_CRASHED.html
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 6 additions & 14 deletions packages/errors/src/errors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -620,22 +620,14 @@ export const AllCypressErrors = {
return errTemplate`\
We detected that the Chromium Renderer process just crashed.

This is the equivalent to seeing the 'sad face' when Chrome dies.
This can happen for a number of different reasons.

This can happen for a number of different reasons:
If you're running lots of tests on a memory intense application.
- Try increasing the CPU/memory on the machine you're running on.
- Try enabling ${fmt.highlight('experimentalMemoryManagement')} in your config file.
- Try lowering ${fmt.highlight('numTestsKeptInMemory')} in your config file during 'cypress open'.
mschile marked this conversation as resolved.
Show resolved Hide resolved

- You wrote an endless loop and you must fix your own code
- You are running Docker (there is an easy fix for this: see link below)
- You are running lots of tests on a memory intense application.
- Try enabling ${fmt.highlight('experimentalMemoryManagement')} in your config file.
- Try lowering ${fmt.highlight('numTestsKeptInMemory')} in your config file.
- You are running in a memory starved VM environment.
- Try enabling ${fmt.highlight('experimentalMemoryManagement')} in your config file.
- Try lowering ${fmt.highlight('numTestsKeptInMemory')} in your config file.
- There are problems with your GPU / GPU drivers
- There are browser bugs in Chromium

You can learn more including how to fix Docker here:
You can learn more here:

https://on.cypress.io/renderer-process-crashed`
},
Expand Down
40 changes: 12 additions & 28 deletions system-tests/__snapshots__/browser_crash_handling_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,22 +20,14 @@ exports['Browser Crash Handling / when the tab crashes in chrome / fails'] = `

We detected that the Chromium Renderer process just crashed.

This is the equivalent to seeing the 'sad face' when Chrome dies.
This can happen for a number of different reasons.

This can happen for a number of different reasons:
If you're running lots of tests on a memory intense application.
- Try increasing the CPU/memory on the machine you're running on.
- Try enabling experimentalMemoryManagement in your config file.
- Try lowering numTestsKeptInMemory in your config file during 'cypress open'.

- You wrote an endless loop and you must fix your own code
- You are running Docker (there is an easy fix for this: see link below)
- You are running lots of tests on a memory intense application.
- Try enabling experimentalMemoryManagement in your config file.
- Try lowering numTestsKeptInMemory in your config file.
- You are running in a memory starved VM environment.
- Try enabling experimentalMemoryManagement in your config file.
- Try lowering numTestsKeptInMemory in your config file.
- There are problems with your GPU / GPU drivers
- There are browser bugs in Chromium

You can learn more including how to fix Docker here:
You can learn more here:

https://on.cypress.io/renderer-process-crashed

Expand Down Expand Up @@ -117,22 +109,14 @@ exports['Browser Crash Handling / when the tab crashes in electron / fails'] = `

We detected that the Chromium Renderer process just crashed.

This is the equivalent to seeing the 'sad face' when Chrome dies.
This can happen for a number of different reasons.

This can happen for a number of different reasons:

- You wrote an endless loop and you must fix your own code
- You are running Docker (there is an easy fix for this: see link below)
- You are running lots of tests on a memory intense application.
- Try enabling experimentalMemoryManagement in your config file.
- Try lowering numTestsKeptInMemory in your config file.
- You are running in a memory starved VM environment.
- Try enabling experimentalMemoryManagement in your config file.
- Try lowering numTestsKeptInMemory in your config file.
- There are problems with your GPU / GPU drivers
- There are browser bugs in Chromium
If you're running lots of tests on a memory intense application.
- Try increasing the CPU/memory on the machine you're running on.
- Try enabling experimentalMemoryManagement in your config file.
- Try lowering numTestsKeptInMemory in your config file during 'cypress open'.

You can learn more including how to fix Docker here:
You can learn more here:

https://on.cypress.io/renderer-process-crashed

Expand Down