feat: improve stability when recording #25837
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,7 +30,7 @@ mainBuildFilters: &mainBuildFilters | |
| - /^release\/\d+\.\d+\.\d+$/ | ||
| # use the following branch as well to ensure that v8 snapshot cache updates are fully tested | ||
| - 'update-v8-snapshot-cache-on-develop' | ||
| - 'fix/preflight' | ||
|
|
||
| # usually we don't build Mac app - it takes a long time | ||
| # but sometimes we want to really confirm we are doing the right thing | ||
|
|
@@ -41,6 +41,7 @@ macWorkflowFilters: &darwin-workflow-filters | |
| - equal: [ develop, << pipeline.git.branch >> ] | ||
| # use the following branch as well to ensure that v8 snapshot cache updates are fully tested | ||
| - equal: [ 'update-v8-snapshot-cache-on-develop', << pipeline.git.branch >> ] | ||
| - equal: [ 'fix/preflight', << pipeline.git.branch >> ] | ||
| - matches: | ||
| pattern: /^release\/\d+\.\d+\.\d+$/ | ||
| value: << pipeline.git.branch >> | ||
|
|
@@ -51,6 +52,7 @@ linuxArm64WorkflowFilters: &linux-arm64-workflow-filters | |
| - equal: [ develop, << pipeline.git.branch >> ] | ||
| # use the following branch as well to ensure that v8 snapshot cache updates are fully tested | ||
| - equal: [ 'update-v8-snapshot-cache-on-develop', << pipeline.git.branch >> ] | ||
| - equal: [ 'fix/preflight', << pipeline.git.branch >> ] | ||
| - matches: | ||
| pattern: /^release\/\d+\.\d+\.\d+$/ | ||
| value: << pipeline.git.branch >> | ||
|
|
@@ -71,6 +73,7 @@ windowsWorkflowFilters: &windows-workflow-filters | |
| # use the following branch as well to ensure that v8 snapshot cache updates are fully tested | ||
| - equal: [ 'lmiller/fixing-vite-windows', << pipeline.git.branch >> ] | ||
| - equal: [ 'update-v8-snapshot-cache-on-develop', << pipeline.git.branch >> ] | ||
| - equal: [ 'fix/preflight', << pipeline.git.branch >> ] | ||
| - matches: | ||
| pattern: /^release\/\d+\.\d+\.\d+$/ | ||
| value: << pipeline.git.branch >> | ||
|
|
@@ -136,7 +139,7 @@ commands: | |
| - run: | ||
| name: Check current branch to persist artifacts | ||
| command: | | ||
| if [[ "$CIRCLE_BRANCH" != "develop" && "$CIRCLE_BRANCH" != "release/"* && "$CIRCLE_BRANCH" != "fix/preflight" && "$CIRCLE_BRANCH" != "update-v8-snapshot-cache-on-develop" ]]; then | ||
| echo "Not uploading artifacts or posting install comment for this branch." | ||
| circleci-agent step halt | ||
| fi | ||
|
|
@@ -1485,6 +1488,30 @@ jobs: | |
| path: /tmp/cypress | ||
| - store-npm-logs | ||
|
|
||
| server-unit-tests-cloud-environment: | ||
| <<: *defaults | ||
| parameters: | ||
| <<: *defaultsParameters | ||
| resource_class: | ||
| type: string | ||
| default: medium | ||
| resource_class: << parameters.resource_class >> | ||
| parallelism: 1 | ||
| steps: | ||
| - restore_cached_workspace | ||
| # TODO: Remove this once we switch off self-hosted M1 runners | ||
| - when: | ||
| condition: | ||
| equal: [ *darwin-arm64-executor, << parameters.executor >> ] | ||
| steps: | ||
| - run: rm -f /tmp/cypress/junit/* | ||
| - run: yarn workspace @packages/server test-unit cloud/environment_spec.ts | ||
| - verify-mocha-results: | ||
| expectedResultCount: 1 | ||
| - store_test_results: | ||
| path: /tmp/cypress | ||
| - store-npm-logs | ||
|
|
||
| server-integration-tests: | ||
| <<: *defaults | ||
| parallelism: 1 | ||
|
|
@@ -2577,6 +2604,7 @@ linux-x64-workflow: &linux-x64-workflow | |
| context: | ||
| - test-runner:upload | ||
| - test-runner:commit-status-checks | ||
| - test-runner:build-binary | ||
| requires: | ||
| - build | ||
| # various testing scenarios, like building full binary | ||
|
|
@@ -2677,6 +2705,7 @@ linux-arm64-workflow: &linux-arm64-workflow | |
| context: | ||
| - test-runner:upload | ||
| - test-runner:commit-status-checks | ||
| - test-runner:build-binary | ||
| executor: linux-arm64 | ||
| resource_class: arm.medium | ||
| requires: | ||
|
|
@@ -2694,6 +2723,12 @@ linux-arm64-workflow: &linux-arm64-workflow | |
| resource_class: arm.medium | ||
| requires: | ||
| - linux-arm64-build | ||
| - server-unit-tests-cloud-environment: | ||
| name: linux-arm64-server-unit-tests-cloud-environment | ||
| executor: linux-arm64 | ||
| resource_class: arm.medium | ||
| requires: | ||
| - linux-arm64-build | ||
|
|
||
| darwin-x64-workflow: &darwin-x64-workflow | ||
| jobs: | ||
|
|
@@ -2717,6 +2752,7 @@ darwin-x64-workflow: &darwin-x64-workflow | |
| - test-runner:sign-mac-binary | ||
| - test-runner:upload | ||
| - test-runner:commit-status-checks | ||
| - test-runner:build-binary | ||
| executor: mac | ||
| resource_class: macos.x86.medium.gen2 | ||
| requires: | ||
|
|
@@ -2740,6 +2776,12 @@ darwin-x64-workflow: &darwin-x64-workflow | |
| resource_class: macos.x86.medium.gen2 | ||
| requires: | ||
| - darwin-x64-build | ||
| - server-unit-tests-cloud-environment: | ||
| name: darwin-x64-driver-server-unit-tests-cloud-environment | ||
| executor: mac | ||
| resource_class: macos.x86.medium.gen2 | ||
|
There was a problem hiding this comment. not sure if this needs to be this big bc these are just unit tests There was a problem hiding this comment. Updated: |
||
| requires: | ||
| - darwin-x64-build | ||
|
|
||
| darwin-arm64-workflow: &darwin-arm64-workflow | ||
| jobs: | ||
|
|
@@ -2762,6 +2804,7 @@ darwin-arm64-workflow: &darwin-arm64-workflow | |
| - test-runner:sign-mac-binary | ||
| - test-runner:upload | ||
| - test-runner:commit-status-checks | ||
| - test-runner:build-binary | ||
| executor: darwin-arm64 | ||
| resource_class: cypress-io/latest_m1 | ||
| requires: | ||
|
|
@@ -2779,6 +2822,12 @@ darwin-arm64-workflow: &darwin-arm64-workflow | |
| resource_class: cypress-io/latest_m1 | ||
| requires: | ||
| - darwin-arm64-build | ||
| - server-unit-tests-cloud-environment: | ||
| name: darwin-arm64-server-unit-tests-cloud-environment | ||
| executor: darwin-arm64 | ||
| resource_class: cypress-io/latest_m1 | ||
| requires: | ||
| - darwin-arm64-build | ||
|
|
||
| windows-workflow: &windows-workflow | ||
| jobs: | ||
|
|
@@ -2819,6 +2868,13 @@ windows-workflow: &windows-workflow | |
| requires: | ||
| - windows-build | ||
|
|
||
| - server-unit-tests-cloud-environment: | ||
| name: windows-server-unit-tests-cloud-environment | ||
| executor: windows | ||
| resource_class: windows.medium | ||
| requires: | ||
| - windows-build | ||
|
|
||
| - create-build-artifacts: | ||
| name: windows-create-build-artifacts | ||
| executor: windows | ||
|
|
@@ -2827,6 +2883,7 @@ windows-workflow: &windows-workflow | |
| - test-runner:sign-windows-binary | ||
| - test-runner:upload | ||
| - test-runner:commit-status-checks | ||
| - test-runner:build-binary | ||
| requires: | ||
| - windows-build | ||
| - test-binary-against-kitchensink-chrome: | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How come this job isn't run against
darwin-arm64andlinux-arm64?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose I could add it. I'm not sure there's much benefit as the logic is platform specific, not architecture specific