Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: internal request preflight #25772

Merged
merged 57 commits into from
Feb 15, 2023
Merged
Show file tree
Hide file tree
Changes from 51 commits
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
0079147
spike
tgriesser Dec 22, 2022
fc1c099
use env var
tgriesser Dec 22, 2022
6f6b7a5
continue iterating on approach
tgriesser Jan 17, 2023
1fe3ed8
Encrypting/decrypting responses
tgriesser Jan 18, 2023
04a734a
run ci
tgriesser Jan 18, 2023
3e305cd
Merge branch 'develop' into tgriesser/spike/spike
tgriesser Jan 18, 2023
1451329
run ci
tgriesser Jan 18, 2023
00893a5
WIP: getting some system tests passing with new setup
tgriesser Jan 25, 2023
06538ce
run ci
tgriesser Jan 25, 2023
df037c1
fixing various tests run ci
tgriesser Jan 26, 2023
33493ee
Merge branch 'develop' into tgriesser/spike/spike
tgriesser Jan 26, 2023
14974dc
fix env var setup, run ci
tgriesser Jan 26, 2023
a73bd6f
debugging run ci
tgriesser Jan 26, 2023
c157fca
Merge branch 'develop' into tgriesser/spike/spike
tgriesser Jan 26, 2023
9df9bda
attempt to fix spec, run ci
tgriesser Jan 26, 2023
148a3db
Fix key, run ci
tgriesser Jan 27, 2023
5fca0bb
fix, run ci
tgriesser Jan 27, 2023
8c2cd13
attempt to get tests going
tgriesser Jan 27, 2023
ff174f9
run ci
tgriesser Jan 27, 2023
739e293
fix tests
tgriesser Jan 27, 2023
6d7faf7
run ci
tgriesser Jan 27, 2023
1c0b739
remove unused dependency
tgriesser Jan 30, 2023
17c3eb0
Add preflight run ci
tgriesser Jan 30, 2023
de45cfe
fix tests, run ci
tgriesser Jan 31, 2023
ef52e26
fix tests, run ci
tgriesser Jan 31, 2023
a0259e6
Merge branch 'develop' into tgriesser/spike/spike
tgriesser Jan 31, 2023
3b0db83
run ci
tgriesser Jan 31, 2023
bdce6fe
Merge branch 'develop' into tgriesser/spike/spike
tgriesser Feb 8, 2023
35253b7
adding system tests for preflight errors, run ci
tgriesser Feb 8, 2023
2d7543d
fix unit tests / system tests, run ci
tgriesser Feb 8, 2023
f5843b2
never retry TransformErrors
tgriesser Feb 8, 2023
cfa3b4f
remove .only, fix logic, run ci
tgriesser Feb 8, 2023
d508a45
fix tests, run ci
tgriesser Feb 9, 2023
7c6ca06
fix tests, run ci
tgriesser Feb 9, 2023
4506a26
fix errors, run ci
tgriesser Feb 9, 2023
ba437cc
dedicated error for decryption failure, run ci
tgriesser Feb 9, 2023
550650b
fix: add fix & test case for 500 error response
tgriesser Feb 9, 2023
d9ebe36
fix: remove duplicate promise, rename Promise -> Bluebird
tgriesser Feb 10, 2023
3ef3e5e
Merge branch 'develop' into tgriesser/spike/spike
tgriesser Feb 10, 2023
c843efd
Update packages/errors/src/errors.ts
tgriesser Feb 10, 2023
65b8de5
update keys, cut build, run ci
tgriesser Feb 11, 2023
9e4c93f
add mac workflows, run ci
tgriesser Feb 11, 2023
643ec33
bump, run ci
tgriesser Feb 11, 2023
dc52971
update meta, run ci
tgriesser Feb 11, 2023
4d20fa6
update workflows, fix env var
tgriesser Feb 12, 2023
7ab9bba
chore: Update v8 snapshot cache (#25776)
github-actions[bot] Feb 12, 2023
80569b8
Merge branch 'develop' into tgriesser/spike/spike
tgriesser Feb 12, 2023
ce0c4b5
run ci
tgriesser Feb 12, 2023
4f75c37
Merge branch 'develop' into tgriesser/spike/spike
ryanthemanuel Feb 13, 2023
8c5e778
Merge branch 'develop' into tgriesser/spike/spike
tgriesser Feb 14, 2023
b3b8ecf
remove platform, cleanup comment
tgriesser Feb 14, 2023
887471c
Merge branch 'develop' into tgriesser/spike/spike
mjhenkes Feb 14, 2023
75d98e0
Apply suggestions from code review
ryanthemanuel Feb 14, 2023
6ca21d6
Merge branch 'develop' into tgriesser/spike/spike
ryanthemanuel Feb 14, 2023
16664d2
Update .github/workflows/update_v8_snapshot_cache.yml
flotwig Feb 14, 2023
4935e17
Merge branch 'develop' into tgriesser/spike/spike
flotwig Feb 14, 2023
1e2663d
Add a few more comments, additional assertion
tgriesser Feb 15, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .circleci/workflows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ mainBuildFilters: &mainBuildFilters
only:
- develop
- /^release\/\d+\.\d+\.\d+$/
- 'mikep/22825-next-middleware'
- 'tgriesser/spike/_spike'
jennifer-shehane marked this conversation as resolved.
Show resolved Hide resolved
ryanthemanuel marked this conversation as resolved.
Show resolved Hide resolved

# usually we don't build Mac app - it takes a long time
# but sometimes we want to really confirm we are doing the right thing
Expand All @@ -37,7 +37,7 @@ macWorkflowFilters: &darwin-workflow-filters
when:
or:
- equal: [ develop, << pipeline.git.branch >> ]
- equal: [ 'mikep/22825-next-middleware', << pipeline.git.branch >> ]
- equal: [ 'tgriesser/spike/_spike', << pipeline.git.branch >> ]
ryanthemanuel marked this conversation as resolved.
Show resolved Hide resolved
- matches:
pattern: /^release\/\d+\.\d+\.\d+$/
value: << pipeline.git.branch >>
Expand All @@ -46,7 +46,7 @@ linuxArm64WorkflowFilters: &linux-arm64-workflow-filters
when:
or:
- equal: [ develop, << pipeline.git.branch >> ]
- equal: [ 'mikep/22825-next-middleware', << pipeline.git.branch >> ]
- equal: [ 'tgriesser/spike/_spike', << pipeline.git.branch >> ]
ryanthemanuel marked this conversation as resolved.
Show resolved Hide resolved
- matches:
pattern: /^release\/\d+\.\d+\.\d+$/
value: << pipeline.git.branch >>
Expand Down Expand Up @@ -130,7 +130,7 @@ commands:
- run:
name: Check current branch to persist artifacts
command: |
if [[ "$CIRCLE_BRANCH" != "develop" && "$CIRCLE_BRANCH" != "release/"* && "$CIRCLE_BRANCH" != "mikep/22825-next-middleware" ]]; then
if [[ "$CIRCLE_BRANCH" != "develop" && "$CIRCLE_BRANCH" != "release/"* && "$CIRCLE_BRANCH" != "tgriesser/spike/_spike" ]]; then
ryanthemanuel marked this conversation as resolved.
Show resolved Hide resolved
echo "Not uploading artifacts or posting install comment for this branch."
circleci-agent step halt
fi
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/update_v8_snapshot_cache.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ on:
- cron: '0 0 * * 3'
push:
branches:
# - tgriesser/spike/spike
flotwig marked this conversation as resolved.
Show resolved Hide resolved
- ryanm/feature/v8-snapshots-auto-pr
- develop
- 'release/**'
Expand Down
8 changes: 7 additions & 1 deletion packages/errors/src/errors.ts
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,13 @@ export const AllCypressErrors = {

${fmt.highlightSecondary(arg1.response)}`
},
CLOUD_UNKNOWN_CREATE_RUN_WARNING: (arg1: {props: any, message: string}) => {
CLOUD_UNKNOWN_CREATE_RUN_WARNING: (arg1: {props?: any, message: string}) => {
if (!Object.keys(arg1.props).length) {
return errTemplate`\
Warning from Cypress Cloud: ${fmt.highlight(arg1.message)}
`
}

return errTemplate`\
Warning from Cypress Cloud: ${fmt.highlight(arg1.message)}

Expand Down
2 changes: 1 addition & 1 deletion packages/server/config/app.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@
"production": {
"api_url": "https://api.cypress.io/"
}
}
}
Loading