Skip to content

Commit

Permalink
address comments from code review [run ci]
Browse files Browse the repository at this point in the history
  • Loading branch information
AtofStryker committed Oct 11, 2024
1 parent 00de09a commit e8ab563
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions packages/server/lib/browsers/firefox.ts
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,7 @@ export async function open (browser: Browser, url: string, options: BrowserLaunc

const profileDir = utils.getProfileDir(browser, options.isTextTerminal)

// Delete the profile directory if in open mode.
// Delete the legacy profile directory if in open mode.
// Cypress does this because profiles are sourced and created differently with geckodriver/webdriver.
// the profile creation method before 13.15.0 will no longer work with geckodriver/webdriver
// and actually corrupts the profile directory from being able to be encoded. Hence, we delete it to prevent any conflicts.
Expand Down Expand Up @@ -513,9 +513,9 @@ export async function open (browser: Browser, url: string, options: BrowserLaunc
// However, since Cypress 13.15.1,
// geckodriver creates unique profile names that copy over the xulstore.json to the used profile.
// The copy is ultimately updated on the unique profile name and is destroyed when the browser is torn down,
// so the values are not persisted. Cypress could hypothetically determine the profile in use, copy the xulstore.json
// so the values are not persisted. Cypress could hypothetically determine the profile is in use, copy the xulstore.json
// out of the profile and try to persist it in the next created profile, but this method is likely error prone as it requires
// moving/copying of files while creation/deletion of profiles occur, plus the ability to coorelate the correct profile to the current run,
// moving/copying of files while creation/deletion of profiles occur, plus the ability to correlate the correct profile to the current run,
// which there are not guarantees we can deterministically do this in open mode.
const sizemode = 'maximized'

Expand Down Expand Up @@ -592,7 +592,7 @@ export async function open (browser: Browser, url: string, options: BrowserLaunc
browserInstanceWrapper.kill = () => undefined

try {
/**
/**
* To set the profile, we use the profile capabilities in firefoxOptions which
* requires the profile to be base64 encoded. The profile will be copied over to whatever
* profile is created by geckodriver stemming from the root profile path.
Expand Down

1 comment on commit e8ab563

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on e8ab563 Oct 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/13.15.1/linux-x64/misc/use_webdriver-e8ab563b783292c1d2b54201ea5e5f4b54bbbd99/cypress.tgz

Please sign in to comment.