Skip to content

Commit

Permalink
chore: fix chrome system tests to work with chrome 114. updates mostl…
Browse files Browse the repository at this point in the history 
…y caused by bugs in screen height in chrome. see https://bugs.chromium.org/p/chromium/issues/detail?id=1416398
  • Loading branch information
@AtofStryker
AtofStryker committed Sep 2, 2023
1 parent 3ffa88a commit 96d7459
Show file tree
Hide file tree
Showing 8 changed files with 79 additions and 89 deletions.
2 changes: 1 addition & 1 deletion system-tests/__snapshots__/browser_crash_handling_spec.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,7 @@ exports['Browser Crash Handling / when the browser process is killed in chrome /
Running: chrome_process_kill.cy.js (1 of 2)
We detected that the Chrome browser process closed unexpectedly.
We detected that the Chrome tab running Cypress tests closed unexpectedly.
We have failed the current spec and aborted the run.
Expand Down
4 changes: 2 additions & 2 deletions system-tests/__snapshots__/component_testing_spec.ts.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -786,9 +786,9 @@ exports['experimentalSingleTabRunMode / executes all specs in a single tab'] = `
(Screenshots)
- /XXX/XXX/XXX/cypress/screenshots/1_fails.cy.js/simple failing spec -- fails (fai (1280x720)
- /XXX/XXX/XXX/cypress/screenshots/1_fails.cy.js/simple failing spec -- fails (fai (1280x603)
led).png
- /XXX/XXX/XXX/cypress/screenshots/1_fails.cy.js/simple failing spec -- fails agai (1280x720)
- /XXX/XXX/XXX/cypress/screenshots/1_fails.cy.js/simple failing spec -- fails agai (1280x603)
n (failed).png
Expand Down
33 changes: 15 additions & 18 deletions system-tests/__snapshots__/headless_spec.ts.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,18 +19,17 @@ exports['e2e headless / tests in headless mode pass'] = `
e2e headless spec
✓ has the expected values for Cypress.browser
✓ has expected HeadlessChrome useragent
✓ has expected launch args
3 passing
2 passing
(Results)
┌────────────────────────────────────────────────────────────────────────────────────────────────┐
│ Tests: 3 │
│ Passing: 3 │
│ Tests: 2 │
│ Passing: 2 │
│ Failing: 0 │
│ Pending: 0 │
│ Skipped: 0 │
Expand All @@ -48,9 +47,9 @@ exports['e2e headless / tests in headless mode pass'] = `
Spec Tests Passing Failing Pending Skipped
┌────────────────────────────────────────────────────────────────────────────────────────────────┐
│ ✔ headless.cy.js XX:XX 3 3 - - - │
│ ✔ headless.cy.js XX:XX 2 2 - - - │
└────────────────────────────────────────────────────────────────────────────────────────────────┘
✔ All specs passed! XX:XX 3 3 - - -
✔ All specs passed! XX:XX 2 2 - - -
`
Expand All @@ -76,18 +75,17 @@ exports['e2e headless / tests in headed mode pass in !electron'] = `
e2e headless spec
✓ has the expected values for Cypress.browser
✓ has expected HeadlessChrome useragent
✓ has expected launch args
3 passing
2 passing
(Results)
┌────────────────────────────────────────────────────────────────────────────────────────────────┐
│ Tests: 3 │
│ Passing: 3 │
│ Tests: 2 │
│ Passing: 2 │
│ Failing: 0 │
│ Pending: 0 │
│ Skipped: 0 │
Expand All @@ -105,9 +103,9 @@ exports['e2e headless / tests in headed mode pass in !electron'] = `
Spec Tests Passing Failing Pending Skipped
┌────────────────────────────────────────────────────────────────────────────────────────────────┐
│ ✔ headless.cy.js XX:XX 3 3 - - - │
│ ✔ headless.cy.js XX:XX 2 2 - - - │
└────────────────────────────────────────────────────────────────────────────────────────────────┘
✔ All specs passed! XX:XX 3 3 - - -
✔ All specs passed! XX:XX 2 2 - - -
`
Expand All @@ -133,18 +131,17 @@ exports['e2e headless / tests in headed mode pass in electron'] = `
e2e headless spec
✓ has the expected values for Cypress.browser
✓ has expected HeadlessChrome useragent
✓ has expected launch args
3 passing
2 passing
(Results)
┌────────────────────────────────────────────────────────────────────────────────────────────────┐
│ Tests: 3 │
│ Passing: 3 │
│ Tests: 2 │
│ Passing: 2 │
│ Failing: 0 │
│ Pending: 0 │
│ Skipped: 0 │
Expand All @@ -162,9 +159,9 @@ exports['e2e headless / tests in headed mode pass in electron'] = `
Spec Tests Passing Failing Pending Skipped
┌────────────────────────────────────────────────────────────────────────────────────────────────┐
│ ✔ headless.cy.js XX:XX 3 3 - - - │
│ ✔ headless.cy.js XX:XX 2 2 - - - │
└────────────────────────────────────────────────────────────────────────────────────────────────┘
✔ All specs passed! XX:XX 3 3 - - -
✔ All specs passed! XX:XX 2 2 - - -
`
4 changes: 2 additions & 2 deletions system-tests/__snapshots__/retries_spec.ts.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ exports['retries / supports retries'] = `
(Screenshots)
- /XXX/XXX/XXX/cypress/screenshots/fail-twice.cy.js/fail twice (failed).png (1280x720)
- /XXX/XXX/XXX/cypress/screenshots/fail-twice.cy.js/fail twice (failed) (attempt 2 (1280x720)
- /XXX/XXX/XXX/cypress/screenshots/fail-twice.cy.js/fail twice (failed).png (1280x603)
- /XXX/XXX/XXX/cypress/screenshots/fail-twice.cy.js/fail twice (failed) (attempt 2 (1280x603)
).png
Expand Down
56 changes: 28 additions & 28 deletions system-tests/__snapshots__/vite_dev_server_fresh_spec.ts.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ We dynamically generated a new test to display this failure.
(Screenshots)
- /XXX/XXX/XXX/cypress/screenshots/AppCompilationError.cy.jsx/An uncaught error wa (1280x720)
- /XXX/XXX/XXX/cypress/screenshots/AppCompilationError.cy.jsx/An uncaught error wa (1280x603)
s detected outside of a test (failed).png
Expand Down Expand Up @@ -165,12 +165,12 @@ https://on.cypress.io/uncaught-exception-from-application
(Screenshots)
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- error on mount (failed) (1280x720)
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- error on mount (failed) (1280x603)
.png
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- sync error (failed).png (1280x720)
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- async error (failed).pn (1280x720)
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- sync error (failed).png (1280x603)
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- async error (failed).pn (1280x603)
g
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- command failure (failed (1280x720)
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- command failure (failed (1280x603)
).png
Expand Down Expand Up @@ -216,7 +216,7 @@ https://on.cypress.io/uncaught-exception-from-application
(Screenshots)
- /XXX/XXX/XXX/cypress/screenshots/MissingReact.cy.jsx/is missing React (failed).p (1280x720)
- /XXX/XXX/XXX/cypress/screenshots/MissingReact.cy.jsx/is missing React (failed).p (1280x603)
ng
Expand Down Expand Up @@ -254,7 +254,7 @@ https://on.cypress.io/uncaught-exception-from-application
(Screenshots)
- /XXX/XXX/XXX/cypress/screenshots/MissingReactInSpec.cy.jsx/is missing React in t (1280x720)
- /XXX/XXX/XXX/cypress/screenshots/MissingReactInSpec.cy.jsx/is missing React in t (1280x603)
his file (failed).png
Expand Down Expand Up @@ -485,7 +485,7 @@ We dynamically generated a new test to display this failure.
(Screenshots)
- /XXX/XXX/XXX/cypress/screenshots/AppCompilationError.cy.jsx/An uncaught error wa (1280x720)
- /XXX/XXX/XXX/cypress/screenshots/AppCompilationError.cy.jsx/An uncaught error wa (1280x603)
s detected outside of a test (failed).png
Expand Down Expand Up @@ -568,12 +568,12 @@ https://on.cypress.io/uncaught-exception-from-application
(Screenshots)
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- error on mount (failed) (1280x720)
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- error on mount (failed) (1280x603)
.png
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- sync error (failed).png (1280x720)
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- async error (failed).pn (1280x720)
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- sync error (failed).png (1280x603)
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- async error (failed).pn (1280x603)
g
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- command failure (failed (1280x720)
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- command failure (failed (1280x603)
).png
Expand Down Expand Up @@ -619,7 +619,7 @@ https://on.cypress.io/uncaught-exception-from-application
(Screenshots)
- /XXX/XXX/XXX/cypress/screenshots/MissingReact.cy.jsx/is missing React (failed).p (1280x720)
- /XXX/XXX/XXX/cypress/screenshots/MissingReact.cy.jsx/is missing React (failed).p (1280x603)
ng
Expand Down Expand Up @@ -657,7 +657,7 @@ https://on.cypress.io/uncaught-exception-from-application
(Screenshots)
- /XXX/XXX/XXX/cypress/screenshots/MissingReactInSpec.cy.jsx/is missing React in t (1280x720)
- /XXX/XXX/XXX/cypress/screenshots/MissingReactInSpec.cy.jsx/is missing React in t (1280x603)
his file (failed).png
Expand Down Expand Up @@ -888,7 +888,7 @@ We dynamically generated a new test to display this failure.
(Screenshots)
- /XXX/XXX/XXX/cypress/screenshots/AppCompilationError.cy.jsx/An uncaught error wa (1280x720)
- /XXX/XXX/XXX/cypress/screenshots/AppCompilationError.cy.jsx/An uncaught error wa (1280x603)
s detected outside of a test (failed).png
Expand Down Expand Up @@ -971,12 +971,12 @@ https://on.cypress.io/uncaught-exception-from-application
(Screenshots)
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- error on mount (failed) (1280x720)
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- error on mount (failed) (1280x603)
.png
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- sync error (failed).png (1280x720)
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- async error (failed).pn (1280x720)
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- sync error (failed).png (1280x603)
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- async error (failed).pn (1280x603)
g
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- command failure (failed (1280x720)
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- command failure (failed (1280x603)
).png
Expand Down Expand Up @@ -1022,7 +1022,7 @@ https://on.cypress.io/uncaught-exception-from-application
(Screenshots)
- /XXX/XXX/XXX/cypress/screenshots/MissingReact.cy.jsx/is missing React (failed).p (1280x720)
- /XXX/XXX/XXX/cypress/screenshots/MissingReact.cy.jsx/is missing React (failed).p (1280x603)
ng
Expand Down Expand Up @@ -1060,7 +1060,7 @@ https://on.cypress.io/uncaught-exception-from-application
(Screenshots)
- /XXX/XXX/XXX/cypress/screenshots/MissingReactInSpec.cy.jsx/is missing React in t (1280x720)
- /XXX/XXX/XXX/cypress/screenshots/MissingReactInSpec.cy.jsx/is missing React in t (1280x603)
his file (failed).png
Expand Down Expand Up @@ -1291,7 +1291,7 @@ We dynamically generated a new test to display this failure.
(Screenshots)
- /XXX/XXX/XXX/cypress/screenshots/AppCompilationError.cy.jsx/An uncaught error wa (1280x720)
- /XXX/XXX/XXX/cypress/screenshots/AppCompilationError.cy.jsx/An uncaught error wa (1280x603)
s detected outside of a test (failed).png
Expand Down Expand Up @@ -1374,12 +1374,12 @@ https://on.cypress.io/uncaught-exception-from-application
(Screenshots)
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- error on mount (failed) (1280x720)
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- error on mount (failed) (1280x603)
.png
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- sync error (failed).png (1280x720)
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- async error (failed).pn (1280x720)
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- sync error (failed).png (1280x603)
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- async error (failed).pn (1280x603)
g
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- command failure (failed (1280x720)
- /XXX/XXX/XXX/cypress/screenshots/Errors.cy.jsx/Errors -- command failure (failed (1280x603)
).png
Expand Down Expand Up @@ -1425,7 +1425,7 @@ https://on.cypress.io/uncaught-exception-from-application
(Screenshots)
- /XXX/XXX/XXX/cypress/screenshots/MissingReact.cy.jsx/is missing React (failed).p (1280x720)
- /XXX/XXX/XXX/cypress/screenshots/MissingReact.cy.jsx/is missing React (failed).p (1280x603)
ng
Expand Down Expand Up @@ -1463,7 +1463,7 @@ https://on.cypress.io/uncaught-exception-from-application
(Screenshots)
- /XXX/XXX/XXX/cypress/screenshots/MissingReactInSpec.cy.jsx/is missing React in t (1280x720)
- /XXX/XXX/XXX/cypress/screenshots/MissingReactInSpec.cy.jsx/is missing React in t (1280x603)
his file (failed).png
Expand Down
Loading

4 comments on commit 96d7459

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 96d7459 Sep 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/13.2.0/linux-x64/chore/update_electron25_and_node18-96d74598111ce5de10d40a5d649fe71bd99a66d8/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 96d7459 Sep 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin arm64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/13.2.0/darwin-arm64/chore/update_electron25_and_node18-96d74598111ce5de10d40a5d649fe71bd99a66d8/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 96d7459 Sep 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/13.2.0/darwin-x64/chore/update_electron25_and_node18-96d74598111ce5de10d40a5d649fe71bd99a66d8/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 96d7459 Sep 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the win32 x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/13.2.0/win32-x64/chore/update_electron25_and_node18-96d74598111ce5de10d40a5d649fe71bd99a66d8/cypress.tgz

Please sign in to comment.