-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Revert "chore: Vite upgrade (#1381)" (#1383)" #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1396 +/- ##
===========================================
+ Coverage 89.68% 93.89% +4.20%
===========================================
Files 19 95 +76
Lines 737 1606 +869
Branches 35 256 +221
===========================================
+ Hits 661 1508 +847
- Misses 76 98 +22
☔ View full report in Codecov by Sentry. |
Passing run #6147 ↗︎
Details:
Review all test suite changes for PR #1396 ↗︎ |
AtofStryker
commented
Sep 3, 2023
3 tasks
chrisbreiding
approved these changes
Sep 6, 2023
will wait to merge this in until cypress-io/cypress#27715 is approved and ready to ship |
cacieprins
approved these changes
Sep 6, 2023
ramosbugs
added a commit
to unflakable/unflakable-javascript
that referenced
this pull request
Sep 9, 2023
ramosbugs
added a commit
to unflakable/unflakable-javascript
that referenced
this pull request
Sep 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 1135329.
this reimplements the vite update to be tested alongside the node/electron upgrade in cypress/cypress-io originally done in #1381
see cypress-io/cypress#27715