-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add possibility to opt-out from printing step attachments when scenario is not successful #1721
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
3400db9
Add a scenario with new format option printStepAttachments
aurelien-reeves b24b7ec
Rename the parameter to printAttachments
aurelien-reeves 6b817be
Merge branch 'main' into opt-out-print-attachments-1136
aurelien-reeves bc898d0
Start a draft for a tutorial
aurelien-reeves 5741a40
Merge branch 'main' into opt-out-print-attachments-1136
aurelien-reeves 1752766
Complete the tutorial
aurelien-reeves 239d62a
Add failing unit test for not printing attachments
16sheep d297365
Add a flag for specifying whether to print attachments
mattwynne e0ea718
Adds printAttachments flag to step formatting functions.
122ccd3
Actually use printAttachments flag
mattwynne fd0cd5b
Merge branch 'main' into opt-out-print-attachments-1136
mattwynne d81f4be
Merge branch 'main' into opt-out-print-attachments-1136
aurelien-reeves 06f0225
Merge branch 'main' into opt-out-print-attachments-1136
aurelien-reeves ac468f2
Finish implementing the printAttachments option
aurelien-reeves 8e014d8
Fix typos
aurelien-reeves 6bb0e48
Use 'boolean' rather than 'Boolean' for consistency
aurelien-reeves 8bdef73
Add some doc in 'formatters.md'
aurelien-reeves File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this content would sit better in
formatters.md
under the "Options" heading; this doc will shrink over time as we decouple config from the CLI.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added some docs in
formatters.md
.However I think keeping the one in
cli.md
could still be relevant?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem!