Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid lazy init exception in DefaultRegistryDataService #198

Merged

Conversation

agrancaric
Copy link
Collaborator

@agrancaric agrancaric commented Feb 9, 2024

Basic information

  • nrich version:
    2.1.1
  • Module:
    nrich-registry

Additional information

Description

Add entity initialization when returning a value from create or update method in DefaultRegistryDataService to avoid lazy init exception.

Summary

Details

Related issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the project's CONTRIBUTING document
  • I have checked my code with the project's static analysis tooling
  • I have formatted my code with the project's IDEA code-style configuration
  • I have checked my code for misspellings
  • I have organized my changes in easy-to-follow commits
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests pass.

@agrancaric agrancaric requested a review from jzrilic February 9, 2024 13:24
@agrancaric agrancaric self-assigned this Feb 9, 2024
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: Patch coverage is 95.12195% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 96.81%. Comparing base (2ffe052) to head (f46641e).

Files Patch % Lines
...t/croz/nrich/registry/data/util/HibernateUtil.java 94.44% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #198      +/-   ##
============================================
- Coverage     96.84%   96.81%   -0.03%     
- Complexity     1272     1289      +17     
============================================
  Files           183      184       +1     
  Lines          2915     2954      +39     
  Branches        254      260       +6     
============================================
+ Hits           2823     2860      +37     
- Misses           38       39       +1     
- Partials         54       55       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@agrancaric agrancaric force-pushed the feature_returniInitializedEntityOnRegistryCreateAndUpdate branch 3 times, most recently from 8ad63c2 to 7ada8b5 Compare February 9, 2024 13:56
@jzrilic jzrilic changed the title Add entity intitialization when returning value from create or update… Avoid lazy init exception in DefaultRegistryDataService Mar 1, 2024
@agrancaric agrancaric force-pushed the feature_returniInitializedEntityOnRegistryCreateAndUpdate branch from 7ada8b5 to 5576b70 Compare March 4, 2024 09:28
@agrancaric agrancaric requested a review from jzrilic March 4, 2024 09:30
… method in DefaultRegistryDataService to avoid lazy init exception
@agrancaric agrancaric force-pushed the feature_returniInitializedEntityOnRegistryCreateAndUpdate branch from 5576b70 to f46641e Compare March 7, 2024 13:36
@jzrilic jzrilic merged commit 1025cfa into master Mar 7, 2024
7 of 8 checks passed
@jzrilic jzrilic deleted the feature_returniInitializedEntityOnRegistryCreateAndUpdate branch March 7, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants