Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support java.sql.Date and java.sql.Timestamp when writing to excel #192

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

agrancaric
Copy link
Collaborator

@agrancaric agrancaric commented Nov 29, 2023

Basic information

  • nrich version:
    2.1.1
  • Module:
    nrich-excel

Additional information

Description

Summary

Add support for java.sql.Date and java.sql.Timestamp formatting when writing to excel

Details

Add support for java.sql.Date and java.sql.Timestamp formatting when writing to excel

Related issue

Types of changes

  • Enhancement (non-breaking change which enhances existing functionality)

Checklist

  • I have read the project's CONTRIBUTING document
  • I have checked my code with the project's static analysis tooling
  • I have formatted my code with the project's IDEA code-style configuration
  • I have checked my code for misspellings
  • I have organized my changes in easy-to-follow commits
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests pass.

@agrancaric agrancaric requested a review from jzrilic November 29, 2023 11:16
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cb1ee62) 96.82% compared to head (050579e) 96.82%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #192   +/-   ##
=========================================
  Coverage     96.82%   96.82%           
  Complexity     1267     1267           
=========================================
  Files           183      183           
  Lines          2899     2899           
  Branches        251      251           
=========================================
  Hits           2807     2807           
  Misses           38       38           
  Partials         54       54           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jzrilic jzrilic changed the title Add support for java.sql.Date and java.sql.Timestamp when writing to … Support java.sql.Date and java.sql.Timestamp when writing to excel Jan 24, 2024
@agrancaric agrancaric self-assigned this Jan 24, 2024
@agrancaric agrancaric force-pushed the feature_addAdditionalDateTypesToExcel branch from 2e3eda5 to 050579e Compare January 24, 2024 14:15
@jzrilic jzrilic merged commit 279566d into master Jan 24, 2024
8 checks passed
@jzrilic jzrilic deleted the feature_addAdditionalDateTypesToExcel branch January 24, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants