-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document automatic dependency downgrade option #874
Conversation
✅ Deploy Preview for crossplane ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
55dd688
to
4d0165a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for following up with this documentation @ezgidemirel, sorry we didn't get it into the release yesterday. Can you please rebase this commit on the latest (post release) and then also copy the content to the v1.19 folder to "backport" it?
|
||
Crossplane can automatically upgrade a package's dependency version to the minimum | ||
valid version that satisfies all the constraints. It's an alpha feature that | ||
requires enabling with the `--enable-dependency-version-upgrades` flag. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we link here to help on how to set feature flags?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added in the following note section
4d0165a
to
b1cea1a
Compare
Signed-off-by: ezgidemirel <ezgidemirel91@gmail.com>
b1cea1a
to
c496974
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks mostly good to me @ezgidemirel, just one small nit about linking directly to the feature flags table, but otherwise this is a helpful addition to the docs! thank you! 🙇♂️
content/master/concepts/packages.md
Outdated
Please check the | ||
[configuration options]({{<ref "../software/install#customize-the-crossplane-helm-chart">}}) | ||
and | ||
[feature flags]({{<ref "../software/install#customize-the-crossplane-helm-chart">}}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this link could be ../software/install/#feature-flags
instead, which goes right to the feature flags
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the catch @jbw976! I copy/pasted it from the pods file didn't notice the wrong reference. I also fixed it in the pods.md
files
content/master/concepts/providers.md
Outdated
Please check the | ||
[configuration options]({{<ref "../software/install#customize-the-crossplane-helm-chart">}}) | ||
and | ||
[feature flags]({{<ref "../software/install#customize-the-crossplane-helm-chart">}}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here, this link could probably be ../software/install/#feature-flags
valid version that satisfies all the constraints. It's an alpha feature that | ||
requires enabling with the `--enable-dependency-version-upgrades` flag. | ||
|
||
In some cases, dependency version downgrade is required for proceeding with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a super helpful description, thank you for adding this! well done 🙇♂️
no new vale errors introduced by this PR, so vale looks OK to me ✅ |
Signed-off-by: ezgidemirel <ezgidemirel91@gmail.com>
6b7e127
to
e98a6d9
Compare
This PR documents how people can enable automatic dependency version upgrade and downgrade functionalities.