Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving api_management(1) resources to v1beta1 version #385

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

svscheg
Copy link
Contributor

@svscheg svscheg commented Feb 23, 2023

Description of your changes

Fixes #383

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Manually
Uptest
azurerm_api_management_global_schema - /~https://github.com/upbound/provider-azure/actions/runs/4261421742/jobs/7415732567

@svscheg
Copy link
Contributor Author

svscheg commented Feb 23, 2023

/test-examples="examples/apimanagement/globalschema.yaml"

1 similar comment
@svscheg
Copy link
Contributor Author

svscheg commented Feb 23, 2023

/test-examples="examples/apimanagement/globalschema.yaml"

@svscheg svscheg force-pushed the appconfiguration_1res branch from 08d1a45 to 15671da Compare February 23, 2023 22:01
@svscheg
Copy link
Contributor Author

svscheg commented Feb 23, 2023

/test-examples="examples/apimanagement/globalschema.yaml"

1 similar comment
@svscheg
Copy link
Contributor Author

svscheg commented Feb 24, 2023

/test-examples="examples/apimanagement/globalschema.yaml"

@svscheg svscheg force-pushed the appconfiguration_1res branch from 15671da to 217205a Compare February 24, 2023 09:42
@svscheg
Copy link
Contributor Author

svscheg commented Feb 24, 2023

/test-examples="examples/apimanagement/globalschema.yaml"

Copy link
Collaborator

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @svscheg LGTM!

@svscheg svscheg requested a review from sergenyalcin February 24, 2023 11:37
@svscheg svscheg merged commit 092a460 into crossplane-contrib:main Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moving api_management(1) resources to v1beta1 version
2 participants