Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump native provider to version 5.19.0 #864

Closed

Conversation

turkenf
Copy link
Collaborator

@turkenf turkenf commented Sep 5, 2023

Description of your changes

In this PR:

  • Native provider version upgraded to 5.15.0

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Changes made in this PR have been tested uptest and manually, please see comments.

@turkenf
Copy link
Collaborator Author

turkenf commented Sep 5, 2023

/test-examples="examples/budgets/budget.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Sep 6, 2023

Breaking CRD schema changes

  • package/crds/acmpca.aws.upbound.io_certificateauthorities.yaml
    Manually: This resource will be tested once after all reviews as it costs over $100 to create.
  • package/crds/apigateway.aws.upbound.io_restapis.yaml
    Manually:
NAME                                                     READY   SYNCED   EXTERNAL-NAME                AGE
documentationversion.apigateway.aws.upbound.io/example   True    True     dlxf1ulsi9/example_version   27m

NAME                                                  READY   SYNCED   EXTERNAL-NAME       AGE
documentationpart.apigateway.aws.upbound.io/example   True    True     dlxf1ulsi9/lu2h9e   27m

NAME                                             READY   SYNCED   EXTERNAL-NAME             AGE
gatewayresponse.apigateway.aws.upbound.io/test   True    True     dlxf1ulsi9/UNAUTHORIZED   27m

NAME                                          READY   SYNCED   EXTERNAL-NAME   AGE
restapi.apigateway.aws.upbound.io/auth-demo   True    True     dlxf1ulsi9      27m

NAME                                        READY   SYNCED   EXTERNAL-NAME   AGE
authorizer.apigateway.aws.upbound.io/demo   True    True     cypiqa          27m

NAME                                           READY   SYNCED   EXTERNAL-NAME   AGE
restapipolicy.apigateway.aws.upbound.io/test   True    True     dlxf1ulsi9      27m

NAME                                              READY   SYNCED   EXTERNAL-NAME             AGE
role.iam.aws.upbound.io/test-invocation-role-ft   True    True     test-invocation-role-ft   27m
NAME                                                             READY   SYNCED   EXTERNAL-NAME        AGE
autoscalinggroup.autoscaling.aws.upbound.io/attachment-example   True    True     attachment-example   7m25s

NAME                                                       READY   SYNCED   EXTERNAL-NAME                                   AGE
attachment.autoscaling.aws.upbound.io/asg-attachment-bar   True    True     attachment-example-20230911144931808700000001   7m2
5s

NAME                                                                READY   SYNCED   EXTERNAL-NAME        AGE
launchconfiguration.autoscaling.aws.upbound.io/attachment-example   True    True     attachment-example   7m25s

NAME                                        READY   SYNCED   EXTERNAL-NAME        AGE
elb.elb.aws.upbound.io/attachment-example   True    True     attachment-example   7m26s
NAME                                                     READY   SYNCED   EXTERNAL-NAME   AGE
launchconfiguration.autoscaling.aws.upbound.io/as-conf   True    True     as-conf         17m

NAME                                                  READY   SYNCED   EXTERNAL-NAME   AGE
autoscalinggroup.autoscaling.aws.upbound.io/example   True    True     example         5m10s
NAME                                                      READY   SYNCED   EXTERNAL-NAME   AGE
launchconfiguration.autoscaling.aws.upbound.io/as-conf    True    True     as-conf         72m
NAME                                  READY   SYNCED   EXTERNAL-NAME   AGE
certificate.dms.aws.upbound.io/test   True    True     test            12m

NAME                               READY   SYNCED   EXTERNAL-NAME   AGE
endpoint.dms.aws.upbound.io/test   True    True     test            4m7s

NAME                             READY   SYNCED   EXTERNAL-NAME                          AGE
key.kms.aws.upbound.io/example   True    True     f7126f88-f5a5-4724-94a6-032707782c07   12m
NAME                                                  READY   SYNCED   EXTERNAL-NAME   AGE
replicationgroup.elasticache.aws.upbound.io/example   True    True     example         20m
NAME                                       READY   SYNCED   EXTERNAL-NAME   AGE
group.cloudwatchlogs.aws.upbound.io/test   True    True     test            146m

NAME                                   READY   SYNCED   EXTERNAL-NAME              AGE
subnet.ec2.aws.upbound.io/subnet-az1   True    True     subnet-07019d9aa24cce898   66m
subnet.ec2.aws.upbound.io/subnet-az2   True    True     subnet-0cc9b9224e23ac5a4   146m

NAME                         READY   SYNCED   EXTERNAL-NAME           AGE
vpc.ec2.aws.upbound.io/vpc   True    True     vpc-029eece97a3ed6065   146m

NAME                                  READY   SYNCED   EXTERNAL-NAME          AGE
securitygroup.ec2.aws.upbound.io/sg   True    True     sg-0df11c8e248adb717   146m

NAME                                             READY   SYNCED   EXTERNAL-NAME                                                    AGE
deliverystream.firehose.aws.upbound.io/example   True    True     arn:aws:firehose:us-west-1:153891904029:deliverystream/example   81m

NAME                                    READY   SYNCED   EXTERNAL-NAME   AGE
role.iam.aws.upbound.io/firehose-role   True    True     firehose-role   146m

NAME                                         READY   SYNCED   EXTERNAL-NAME
                 AGE
configuration.kafka.aws.upbound.io/example   True    True     arn:aws:kafka:us-west-1:153891904029:configuration/example/2f3d61ed-c443-432f-bd33-
64c6f282dfea-3   12m

NAME                                   READY   SYNCED   EXTERNAL-NAME
     AGE
cluster.kafka.aws.upbound.io/example   True    True     arn:aws:kafka:us-west-1:153891904029:cluster/example/2c99e9a1-691f-4adb-bb46-cd96084aab08
-3   64m

NAME                         READY   SYNCED   EXTERNAL-NAME                          AGE
key.kms.aws.upbound.io/kms   True    True     415f4ae0-9376-4154-b448-e92449b61040   146m

NAME                                    READY   SYNCED   EXTERNAL-NAME   AGE
bucket.s3.aws.upbound.io/cl-test-ft55   True    True     cl-test-ft55    146m
NAME                              READY   SYNCED   EXTERNAL-NAME   AGE
role.iam.aws.upbound.io/channel   True    True     channel         33m

NAME                                                  READY   SYNCED   EXTERNAL-NAME   AGE
inputsecuritygroup.medialive.aws.upbound.io/channel   True    True     6127166         40m

NAME                                       READY   SYNCED   EXTERNAL-NAME   AGE
channel.medialive.aws.upbound.io/channel   True    True     6942070         33m

NAME                                     READY   SYNCED   EXTERNAL-NAME   AGE
input.medialive.aws.upbound.io/channel   True    True     2871723         33m

NAME                                       READY   SYNCED   EXTERNAL-NAME     AGE
bucket.s3.aws.upbound.io/channel1-tftest   True    True     channel1-tftest   33m
bucket.s3.aws.upbound.io/channel2-tftest   True    True     channel2-tftest   33m

Native schema version changes

NAME                                                                 READY   SYNCED   EXTERNAL-NAME
                    AGE
provisionedconcurrencyconfig.lambda.aws.upbound.io/example-ft-test   True    True     arn:aws:lambda:us-west-1:153891904029:fun
ction:exampletf,1   9m33s

@turkenf
Copy link
Collaborator Author

turkenf commented Sep 6, 2023

/test-examples="examples/connect/hoursofoperation.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Sep 6, 2023

/test-examples="examples/directconnect/connection.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Sep 6, 2023

/test-examples="examples/ec2/defaultvpc.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Sep 6, 2023

/test-examples="examples/connect/queue.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Sep 6, 2023

/test-examples="examples/ec2/route.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Sep 6, 2023

/test-examples="examples/connect/routingprofile.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Sep 6, 2023

/test-examples="examples/ec2/routetable.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Sep 6, 2023

/test-examples="examples/ec2/routetableassociation.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Sep 6, 2023

/test-examples="examples/ec2/vpcpeeringconnectionaccepter.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Sep 6, 2023

/test-examples="examples/elasticache/cluster.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Sep 6, 2023

/test-examples="examples/firehose/deliverystream.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Sep 6, 2023

/test-examples="examples/iam/role.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Sep 6, 2023

/test-examples="examples/ec2/vpcpeeringconnectionoption.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Sep 6, 2023

/test-examples="examples/elasticache/replicationgroup.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Sep 6, 2023

/test-examples="examples/lightsail/instance.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Sep 6, 2023

/test-examples="examples/networkmanager/corenetwork.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Sep 6, 2023

/test-examples="examples/redshift/cluster.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Sep 6, 2023

/test-examples="examples/secretsmanager/secret.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Sep 6, 2023

/test-examples="examples/transfer/server.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Sep 6, 2023

/test-examples="examples/ec2/vpcpeeringconnectionoptions.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Sep 6, 2023

/test-examples="examples/ecs/cluster.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Sep 6, 2023

/test-examples="examples/ec2/vpcpeeringconnection.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Sep 6, 2023

/test-examples="examples/elasticache/replicationgroup.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Sep 6, 2023

/test-examples="examples/firehose/deliverystream.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Sep 6, 2023

/test-examples="examples/rds/instance.yaml"

@ulucinar ulucinar force-pushed the native-provider-bump-5.15.0 branch from c58e73e to dd5f868 Compare October 3, 2023 08:07
@ulucinar
Copy link
Collaborator

ulucinar commented Oct 3, 2023

Hi @turkenf,
While rebasing the PR, I resolved a conflict in examples/kafka/cluster.yaml by accepting the @mbbush's changes. Changes from the feature branch were adding the manual-intervention annotation whereas Matthew has added the Configuration.kafka resource as a dependency. I assume Matthew's changes make the resource uptestable. Will trigger an uptest below.

@ulucinar
Copy link
Collaborator

ulucinar commented Oct 3, 2023

/test-examples="examples/kafka/cluster.yaml"

@ulucinar ulucinar force-pushed the native-provider-bump-5.15.0 branch from caf6221 to d12f733 Compare October 4, 2023 16:54
@ulucinar
Copy link
Collaborator

ulucinar commented Oct 5, 2023

/test-examples="examples/kafka/cluster.yaml"

@ulucinar
Copy link
Collaborator

ulucinar commented Oct 5, 2023

/test-examples="examples/ec2/vpc.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Oct 5, 2023

After bumping version 5.15.0 to 5.19.0:

Breaking CRD schema changes

  • package/crds/sesv2.aws.upbound.io_emailidentities.yaml

Native schema version changes

  • aws_servicecatalog_principal_portfolio_association

@turkenf turkenf changed the title Bump native provider to version 5.15.0 Bump native provider to version 5.19.0 Oct 5, 2023
@turkenf
Copy link
Collaborator Author

turkenf commented Oct 5, 2023

/test-examples="examples/sesv2/emailidentity.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Oct 5, 2023

/test-examples="examples/servicecatalog/principalportfolioassociation.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Oct 5, 2023

/test-examples="examples/rds/instance.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Oct 5, 2023

/test-examples="examples/sesv2/emailidentity.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Oct 5, 2023

/test-examples="examples/servicecatalog/principalportfolioassociation.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Nov 7, 2023

/test-examples="examples/docdb/cluster.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Nov 7, 2023

test-examples="examples/docdb/clusterparametergroup.yaml"

1 similar comment
@turkenf
Copy link
Collaborator Author

turkenf commented Nov 7, 2023

test-examples="examples/docdb/clusterparametergroup.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Nov 7, 2023

/test-examples="examples/docdb/clustersnapshot.yaml"

@turkenf turkenf marked this pull request as draft November 28, 2023 13:46
@ulucinar
Copy link
Collaborator

Hi @turkenf,
Could you please cherry-pick the configuration changes from this PR to #1037? I believe it will be easier for us to continue with #1037 instead of rebasing this PR. What do you think?

@turkenf
Copy link
Collaborator Author

turkenf commented Jan 5, 2024

Covered in #1037

@turkenf turkenf closed this Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants