Rename "scrap" to "scrape". #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpereira
force-pushed
the
rename-scrap-to-scrape
branch
from
43777b1 to
63dd704
Compare
mpereira
force-pushed
the
rename-scrap-to-scrape
branch
from
63dd704 to
30a5eb5
Compare
|
Thanks :) |
|
FTR, I just learned about this backwards-incompatible change the hard way 💥 |
|
Alternatively, you might decide to still support the old spelling as deprecated, and drop that at the next major version bump... |
|
My bad, I was sure to had rejected this PR I didn't want to cause breaking change for end-user as scrap is a valid term also used by Prometheus. I am going to revert it and create a new release. P.s: It was another one with on the same topic #71 |
|
It is reverted in 2.3.4, you will need to update again your config for it to be the old way. Again sorry about that... and thank you for reporting the issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was this the intended word to be used?