Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete LinkerDuplicateSymbolsLocationCaptureGroup #368

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

cpisciotta
Copy link
Owner

@cpisciotta cpisciotta commented Feb 10, 2025

As a prerequisite to #365, delete this overly-generic definition that conflicts with ShellCommandCaptureGroup. Given there aren't tests against this regular expression, it's unclear what output it actually expects and how it differs from LinkerDuplicateSymbolsCaptureGroup. Given this definition is formatted as nil output, we can safely delete this type; deleting this type won't impact user-facing logs, so the only known trade-off is a potential time regression.

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.52%. Comparing base (9a55533) to head (423f4dd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #368      +/-   ##
==========================================
+ Coverage   90.20%   90.52%   +0.32%     
==========================================
  Files          17       17              
  Lines        2481     2470      -11     
==========================================
- Hits         2238     2236       -2     
+ Misses        243      234       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cpisciotta cpisciotta marked this pull request as ready for review February 10, 2025 01:58
@cpisciotta cpisciotta merged commit 22a6689 into main Feb 10, 2025
15 checks passed
@cpisciotta cpisciotta deleted the charles/LinkerDuplicateSymbolsLocationCaptureGroup branch February 10, 2025 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant