-
Notifications
You must be signed in to change notification settings - Fork 143
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Major Packaging Refactor: migrate to uv (#377)
Based upon the /~https://github.com/fpgmaas/cookiecutter-uv repository with some modifications. This should simplify python version management.
- Loading branch information
1 parent
eb44bff
commit ade65a1
Showing
36 changed files
with
2,082 additions
and
978 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
name: "Setup Python Environment" | ||
description: "Set up Python environment for the given Python version" | ||
|
||
inputs: | ||
python-version: | ||
description: "Python version to use" | ||
required: true | ||
default: "3.12" | ||
uv-version: | ||
description: "uv version to use" | ||
required: true | ||
default: "0.6.2" | ||
|
||
runs: | ||
using: "composite" | ||
steps: | ||
- name: Install uv | ||
uses: astral-sh/setup-uv@v5 | ||
with: | ||
version: ${{ inputs.uv-version }} | ||
enable-cache: true | ||
python-version: ${{ inputs.python-version }} | ||
- name: Install Python dependencies | ||
run: uv sync --frozen | ||
shell: bash |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
name: Main | ||
|
||
on: | ||
push: | ||
branches: | ||
- main | ||
pull_request: | ||
types: [opened, synchronize, reopened, ready_for_review] | ||
|
||
jobs: | ||
quality: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Check out | ||
uses: actions/checkout@v4 | ||
|
||
- uses: actions/cache@v4 | ||
with: | ||
path: ~/.cache/pre-commit | ||
key: pre-commit-${{ hashFiles('.pre-commit-config.yaml') }} | ||
|
||
- name: Set up the environment | ||
uses: ./.github/actions/setup-python-env | ||
|
||
- name: Run checks | ||
run: make check | ||
|
||
tests-and-type-check: | ||
runs-on: ubuntu-latest | ||
strategy: | ||
matrix: | ||
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"] | ||
fail-fast: false | ||
defaults: | ||
run: | ||
shell: bash | ||
steps: | ||
- name: Check out | ||
uses: actions/checkout@v4 | ||
|
||
- name: Set up the environment | ||
uses: ./.github/actions/setup-python-env | ||
with: | ||
python-version: ${{ matrix.python-version }} | ||
|
||
- name: Run tests | ||
run: uv run python -m pytest tests --cov --cov-config=pyproject.toml --cov-report=xml | ||
|
||
# - name: Check typing | ||
# run: uv run mypy . | ||
|
||
- name: Upload coverage reports to Codecov with GitHub Action on Python 3.11 | ||
uses: codecov/codecov-action@v4 | ||
if: ${{ matrix.python-version == '3.11' }} | ||
|
||
check-docs: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Check out | ||
uses: actions/checkout@v4 | ||
|
||
- name: Set up the environment | ||
uses: ./.github/actions/setup-python-env | ||
|
||
- name: Check if documentation can be built | ||
run: uv run mkdocs build |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
name: release-main | ||
|
||
on: | ||
release: | ||
types: [published] | ||
|
||
jobs: | ||
set-version: | ||
runs-on: ubuntu-24.04 | ||
steps: | ||
- uses: actions/checkout@v4 | ||
|
||
- name: Export tag | ||
id: vars | ||
run: echo tag=${GITHUB_REF#refs/*/} >> $GITHUB_OUTPUT | ||
if: ${{ github.event_name == 'release' }} | ||
|
||
- name: Update project version | ||
run: | | ||
sed -i "s/^version = \".*\"/version = \"$RELEASE_VERSION\"/" pyproject.toml | ||
sed -i "s/__version__ .*/__version__ = \"$RELEASE_VERSION\"/" flask_cors/version.py | ||
env: | ||
RELEASE_VERSION: ${{ steps.vars.outputs.tag }} | ||
if: ${{ github.event_name == 'release' }} | ||
|
||
- name: Upload updated pyproject.toml | ||
uses: actions/upload-artifact@v4 | ||
with: | ||
name: pyproject-toml | ||
path: pyproject.toml | ||
|
||
publish: | ||
runs-on: ubuntu-latest | ||
needs: [set-version] | ||
steps: | ||
- name: Check out | ||
uses: actions/checkout@v4 | ||
|
||
- name: Set up the environment | ||
uses: ./.github/actions/setup-python-env | ||
|
||
- name: Download updated pyproject.toml | ||
uses: actions/download-artifact@v4 | ||
with: | ||
name: pyproject-toml | ||
|
||
- name: Build package | ||
run: uv build | ||
|
||
- name: Publish package | ||
run: uv publish | ||
|
||
deploy-docs: | ||
needs: publish | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Check out | ||
uses: actions/checkout@v4 | ||
|
||
- name: Set up the environment | ||
uses: ./.github/actions/setup-python-env | ||
|
||
- name: Deploy documentation | ||
run: uv run mkdocs gh-deploy --force |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
name: validate-codecov-config | ||
|
||
on: | ||
pull_request: | ||
paths: [codecov.yaml] | ||
push: | ||
branches: [main] | ||
|
||
jobs: | ||
validate-codecov-config: | ||
runs-on: ubuntu-22.04 | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- name: Validate codecov configuration | ||
run: curl -sSL --fail-with-body --data-binary @codecov.yaml https://codecov.io/validate |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
repos: | ||
- repo: /~https://github.com/pre-commit/pre-commit-hooks | ||
rev: "v4.4.0" | ||
hooks: | ||
- id: check-case-conflict | ||
- id: check-merge-conflict | ||
- id: check-toml | ||
- id: check-yaml | ||
- id: end-of-file-fixer | ||
- id: trailing-whitespace | ||
|
||
- repo: /~https://github.com/astral-sh/ruff-pre-commit | ||
rev: "v0.6.3" | ||
hooks: | ||
- id: ruff | ||
args: [--exit-non-zero-on-fix] | ||
- id: ruff-format | ||
|
||
- repo: /~https://github.com/pre-commit/mirrors-prettier | ||
rev: "v3.0.3" | ||
hooks: | ||
- id: prettier |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,126 @@ | ||
# Contributing to `flask-cors` | ||
|
||
Contributions are welcome, and they are greatly appreciated! | ||
Every little bit helps, and credit will always be given. | ||
|
||
You can contribute in many ways: | ||
|
||
# Types of Contributions | ||
|
||
## Report Bugs | ||
|
||
Report bugs at /~https://github.com/corydolphin/flask-cors/issues | ||
|
||
If you are reporting a bug, please include: | ||
|
||
- Your operating system name and version. | ||
- Any details about your local setup that might be helpful in troubleshooting. | ||
- Detailed steps to reproduce the bug. | ||
|
||
## Fix Bugs | ||
|
||
Look through the GitHub issues for bugs. | ||
Anything tagged with "bug" and "help wanted" is open to whoever wants to implement a fix for it. | ||
|
||
## Implement Features | ||
|
||
Look through the GitHub issues for features. | ||
Anything tagged with "enhancement" and "help wanted" is open to whoever wants to implement it. | ||
|
||
## Write Documentation | ||
|
||
flask-cors could always use more documentation, whether as part of the official docs, in docstrings, or even on the web in blog posts, articles, and such. | ||
|
||
## Submit Feedback | ||
|
||
The best way to send feedback is to file an issue at /~https://github.com/corydolphin/flask-cors/issues. | ||
|
||
If you are proposing a new feature: | ||
|
||
- Explain in detail how it would work. | ||
- Keep the scope as narrow as possible, to make it easier to implement. | ||
- Remember that this is a volunteer-driven project, and that contributions | ||
are welcome :) | ||
|
||
# Get Started! | ||
|
||
Ready to contribute? Here's how to set up `flask-cors` for local development. | ||
Please note this documentation assumes you already have `uv` and `Git` installed and ready to go. | ||
|
||
1. Fork the `flask-cors` repo on GitHub. | ||
|
||
2. Clone your fork locally: | ||
|
||
```bash | ||
cd <directory_in_which_repo_should_be_created> | ||
git clone git@github.com:YOUR_NAME/flask-cors.git | ||
``` | ||
|
||
3. Now we need to install the environment. Navigate into the directory | ||
|
||
```bash | ||
cd flask-cors | ||
``` | ||
|
||
Then, install and activate the environment with: | ||
|
||
```bash | ||
uv sync | ||
``` | ||
|
||
4. Install pre-commit to run linters/formatters at commit time: | ||
|
||
```bash | ||
uv run pre-commit install | ||
``` | ||
|
||
5. Create a branch for local development: | ||
|
||
```bash | ||
git checkout -b name-of-your-bugfix-or-feature | ||
``` | ||
|
||
Now you can make your changes locally. | ||
|
||
6. Don't forget to add test cases for your added functionality to the `tests` directory. | ||
|
||
7. When you're done making changes, check that your changes pass the formatting tests. | ||
|
||
```bash | ||
make check | ||
``` | ||
|
||
Now, validate that all unit tests are passing: | ||
|
||
```bash | ||
make test | ||
``` | ||
|
||
9. Before raising a pull request you should also run tox. | ||
This will run the tests across different versions of Python: | ||
|
||
```bash | ||
tox | ||
``` | ||
|
||
This requires you to have multiple versions of python installed. | ||
This step is also triggered in the CI/CD pipeline, so you could also choose to skip this step locally. | ||
|
||
10. Commit your changes and push your branch to GitHub: | ||
|
||
```bash | ||
git add . | ||
git commit -m "Your detailed description of your changes." | ||
git push origin name-of-your-bugfix-or-feature | ||
``` | ||
|
||
11. Submit a pull request through the GitHub website. | ||
|
||
# Pull Request Guidelines | ||
|
||
Before you submit a pull request, check that it meets these guidelines: | ||
|
||
1. The pull request should include tests. | ||
|
||
2. If the pull request adds functionality, the docs should be updated. | ||
Put your new functionality into a function with a docstring, and add the feature to the list in `README.md`. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
Copyright (C) 2016 Cory Dolphin, Olin College | ||
Copyright (C) 2025 Cory Dolphin | ||
|
||
Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: | ||
|
||
The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. | ||
|
||
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. | ||
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. |
Oops, something went wrong.