Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update prometheus version to v3.1.0 #6583

Merged
merged 4 commits into from
Feb 27, 2025
Merged

Update prometheus version to v3.1.0 #6583

merged 4 commits into from
Feb 27, 2025

Conversation

SungJin1212
Copy link
Contributor

@SungJin1212 SungJin1212 commented Feb 12, 2025 •
edited
Loading

This PR updates the Prometheus version to v3.1.0.
Changed things:

Related PRs:

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • [NA] Documentation added
  • [NA] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@SungJin1212 SungJin1212 marked this pull request as draft February 12, 2025 10:23
@dosubot dosubot bot added the dependencies Pull requests that update a dependency file label Feb 12, 2025
@SungJin1212 SungJin1212 force-pushed the Update-prometheus-v3.1.0 branch 2 times, most recently from 0f3c969 to 9bb78a0 Compare February 12, 2025 10:31
@SungJin1212 SungJin1212 marked this pull request as ready for review February 13, 2025 05:41
@dosubot dosubot bot added the go Pull requests that update Go code label Feb 13, 2025
@alanprot
Copy link
Member

@yeya24 How the fuzzy test will work here?

Will it pick the new functions from Prometheus 3.0? In this case those functions will fail on the "older" cortex releases?

@yeya24
Copy link
Contributor

yeya24 commented Feb 18, 2025

@alanprot The new functions in Prometheus 3.0 is behind a feature flag. We only have one test case that enables experimental functions.

It is currently testing against Prometheus 2.55.1 now. If we want it to be compatible we can upgrade to Prometheus 3.0

yeya24
yeya24 reviewed Feb 18, 2025
View reviewed changes
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the change in the promql engine prometheus/prometheus#14930, can we try to backport holt_winter so that it is easier for users to migrate to newer Cortex version?

We can keep holt winter until the new function is marked as ready.

@SungJin1212 SungJin1212 force-pushed the Update-prometheus-v3.1.0 branch 3 times, most recently from 97a4183 to 36662dd Compare February 19, 2025 04:37
@SungJin1212
Copy link
Contributor Author

@yeya24
I added holt_winters function and dedicated e2e test.

@alanprot
Copy link
Member

alanprot commented Feb 19, 2025 •
edited
Loading

The fuzzy is failing now: =/

        err2: bad_data: invalid parameter "query": 2:3: parse error: unknown function with name "holt_winters"

@SungJin1212 SungJin1212 force-pushed the Update-prometheus-v3.1.0 branch from 18feb34 to 81edd16 Compare February 20, 2025 08:32
@SungJin1212 SungJin1212 force-pushed the Update-prometheus-v3.1.0 branch 2 times, most recently from a0da2c1 to 32ef5d3 Compare February 21, 2025 04:32
yeya24
yeya24 reviewed Feb 23, 2025
View reviewed changes
@SungJin1212 SungJin1212 force-pushed the Update-prometheus-v3.1.0 branch from 32ef5d3 to de28ee1 Compare February 24, 2025 02:44
@SungJin1212 SungJin1212 force-pushed the Update-prometheus-v3.1.0 branch 2 times, most recently from 437de37 to d22816c Compare February 24, 2025 11:05
@friedrichg friedrichg changed the title Update prometheus verison to v3.1.0 Update prometheus version to v3.1.0 Feb 25, 2025
friedrichg
friedrichg approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@friedrichg friedrichg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 25, 2025
danielblando
danielblando approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@danielblando danielblando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thanks

@SungJin1212
Update prometheus verison to v3.1.0
97f9781 
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
@SungJin1212
Fix test
f73755c 
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
@SungJin1212
Add sloglint
4c5e97b 
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
@SungJin1212
Support holt_winters function
2dbc409 
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
@SungJin1212 SungJin1212 force-pushed the Update-prometheus-v3.1.0 branch from d22816c to 2dbc409 Compare February 26, 2025 01:41
alanprot
alanprot approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@alanprot alanprot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!!

@yeya24 yeya24 merged commit 940adf6 into cortexproject:master Feb 27, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielblando danielblando danielblando approved these changes

@friedrichg friedrichg friedrichg approved these changes

@alanprot alanprot alanprot approved these changes

@yeya24 yeya24 yeya24 approved these changes

@rajagopalanand rajagopalanand Awaiting requested review from rajagopalanand

@CharlieTLe CharlieTLe Awaiting requested review from CharlieTLe

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code lgtm This PR has been approved by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SungJin1212 @alanprot @yeya24 @danielblando @friedrichg