This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
[fix] change timeout interval #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haosap
suggested changes
Jun 17, 2020
Comment on lines
+190
to
+191
| Connectivity.urlSessionConfiguration.timeoutIntervalForRequest = 15.0 | ||
| Connectivity.urlSessionConfiguration.timeoutIntervalForResource = 15.0 |
| @@ -186,6 +187,8 @@ final class SceneDelegate: UIResponder, UIWindowSceneDelegate, RequiresAppDepend | |||
| } | |||
|
|
|||
| private func presentHomeVC() { | |||
| Connectivity.urlSessionConfiguration.timeoutIntervalForRequest = 15.0 | |||
| Connectivity.urlSessionConfiguration.timeoutIntervalForResource = 15.0 | |||
| enStateHandler = ENStateHandler( | |||
| initialExposureManagerState: exposureManager.preconditions(), | |||
| reachabilityService: ConnectivityReachabilityService( | |||
There was a problem hiding this comment.
In fact, the EnStateHandler has a strong reference to ConnectivityReachabilityService and meanwhile, ConnectivityReachabilityService also keeps the strong ref to EnStateHandler. please check it.
haosap
approved these changes
Jun 17, 2020
ChristianKienle
approved these changes
Jun 17, 2020
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
increase timeout interval to avoid wrong internet off states