This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Fix/14992 EOL - Remove notifications syncronously #5140
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
UNUserNotificationCenter.current().removeAllPendingNotificationRequests()
which will do the same but synchronously.The downside of reverting the previous code:
We wont be able to stop notifications in the future if the EOL is not reached yet. e.g today is 3/4/2023 Eol is 4/4/2023 and we have a notification scheduled in 5/4/2023. this notification will not be canceled unless the user tries to open, close, of move the app to background DURING End of life.
a redundant call was removed from
applicationDidEnterBackground()
as we will cancel anyway inapplicationWillResignActive()
which has to be called beforeapplicationDidEnterBackground
, so need to cancel twiceLink to Jira
https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-14992