Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fiddle as an explicit dependency since it will be removed in Ruby 3.5.0 #111

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

kryali
Copy link
Contributor

@kryali kryali commented Jan 18, 2025

in ruby 3.4.1 I received a new warning from einhorn announcing the removal of fiddle from the standard library

/usr/local/bundle/gems/einhorn-1.0.0/lib/einhorn/prctl_linux.rb:1: warning: /usr/local/lib/ruby/3.4.0/fiddle.rb was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add fiddle to your Gemfile or gemspec to silence this warning.
Also please contact the author of einhorn-1.0.0 to request adding fiddle into its gemspec.

Feel free to decline this PR if another approach is more appropriate

@mperham
Copy link
Collaborator

mperham commented Jan 18, 2025

Lots of failures

@kryali
Copy link
Contributor Author

kryali commented Jan 18, 2025

@mperham are these CI failures on main already?

revert on my fork fails /~https://github.com/kryali/einhorn/actions/runs/12846878302

@mperham
Copy link
Collaborator

mperham commented Jan 18, 2025

Yeah, they're on main already. I'm looking into it but no ETA. Code rot can be tricky to fix.

@mperham
Copy link
Collaborator

mperham commented Jan 18, 2025

Ok, I've got all but one test running successfully. The one test fails on every Ruby, I suspect it's a bad test but I don't know enough about what it's trying to verify. /~https://github.com/contribsys/einhorn/actions/runs/12847054762

@mperham mperham merged commit 19a3988 into contribsys:main Jan 18, 2025
2 of 6 checks passed
@kryali
Copy link
Contributor Author

kryali commented Jan 18, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants