podman-run: clean up some formatting issues #911
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miabbott Sign your PR, please. |
|
@miabbott Did you verify these still look good as man pages as well as when viewed in markdown? |
|
@rhatdan I did not....so this PR is probably going to need more work |
Signed-off-by: Micah Abbott <miabbott@redhat.com>
|
@rhatdan Looks like I got lucky with my changes...man page looks reasonable, nothing broken AFAICT. I force pushed a new commit that I've signed. |
|
LGTM @TomSweeneyRedHat PTAL |
|
📌 Commit d60e541 has been approved by |
wking
reviewed
Jun 6, 2018
| # podman run -it --blkio-weight-device "/dev/sda:200" ubuntu | ||
|
|
||
| ``` | ||
| $ podman run -d busybox top |
There was a problem hiding this comment.
It didn't look like it fit in with the --blkio-weight-device example.
I could be misunderstanding how that example works, though.
|
☀️ Test successful - status-papr |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was browsing this page from the repo and some of the formatting was ugly.
This is a shot at cleaning some of it up.
Rendered version can be seen here: /~https://github.com/miabbott/libpod/blob/fmt-podman-run/docs/podman-run.1.md