-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quadlet test - Split between success, warning and error cases #23443
Quadlet test - Split between success, warning and error cases #23443
Conversation
We were not able to find or create Copr project
Unless the HTTP status code above is >= 500, please check your configuration for:
|
@Luap99 PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this looks much cleaner
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, ygalblum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Split the table to three based on the expected outcome Use helper functions to reduce the amount of parameter required in each entry Remove the service name override code Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
d7b19a3
to
7d9c1a2
Compare
I've opened #23449 as draft on top of this PR. I still need to add tests to it and I will also rebase it on main once this one is merged |
/lgtm |
Split the table to three based on the expected outcome
Use helper functions to reduce the amount of parameter required in each entry
Does this PR introduce a user-facing change?
No