Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build API: accept platform comma separated #23103

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Jun 25, 2024

The docker API uses only a single arg for platform and multiple platforms are given as comma separated list.

Fixes #22071

Does this PR introduce a user-facing change?

The build API now accepts platform values comma separated to better match docker.

The docker API uses only a single arg for platform and multiple
platforms are given as comma separated list.

Fixes containers#22071

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Copy link
Contributor

openshift-ci bot commented Jun 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2024
@github-actions github-actions bot added the kind/api-change Change to remote API; merits scrutiny label Jun 25, 2024
@baude
Copy link
Member

baude commented Jun 25, 2024

LGTM

@ashley-cui
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 5e27243 into containers:main Jun 25, 2024
90 checks passed
@Luap99 Luap99 deleted the build-platform branch June 26, 2024 07:57
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 25, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Change to remote API; merits scrutiny lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to build multi-arch via Podman CURL / API.
3 participants