Add support for cgroups configuration #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to be able to disable cgroups when running container engines inside of containers. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
|
LGTM, but issue containers/podman#5488 (comment) said disable cgroup didn't help |
|
@QiWang19 Right, I will have a PR for podman to handle this new flag. |
| `enabled` Enable cgroup support within container | ||
| `disabled` Disable cgroup support, will inherit cgroups from parent | ||
| `no-conmon` Container engine runs run without conmon | ||
|
|
There was a problem hiding this comment.
Side question. I thought at first that we should add a link to the conmon man page here too, but it doesn't have one. Is that something that should happen? Otherwise will most folks know what running without conmon means?
There was a problem hiding this comment.
I think that means "do not create a cgroup for conmon", otherwise systemd can get confused when conmon is moved to a different cgroup
|
LGTM |
|
@TomSweeneyRedHat I have no idea what that field is for. Maybe @giuseppe or @haircommander know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to be able to disable cgroups when running container engines inside of containers.
Signed-off-by: Daniel J Walsh dwalsh@redhat.com